prunes empty segments #1281
Merged
prunes empty segments #1281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filters out empty segments from the specification. An empty segment breaks, in particular, the primus loader which treats it as a segment that covers all addresses (an appropriate assert is added to make it easier to discover such issues in the future).
ivg
added a commit
to ivg/bap
that referenced
this pull request
Mar 19, 2021
It looks like that BinaryAnalysisPlatform#1281 rendered bap useless for unlifted instructions. Both mc and objdump commads are now outputing empty objects even without asm or opcodes, which makes it really hard to write a new lifter. This PR fixes it on mc and objdump level. I am not sure if we also need this in the disassembler driver (as in any case the output of this driver will be incorrect without having full semantics).
ivg
added a commit
that referenced
this pull request
Mar 19, 2021
It looks like that #1281 rendered bap useless for unlifted instructions. Both mc and objdump commads are now outputing empty objects even without asm or opcodes, which makes it really hard to write a new lifter. This PR fixes it on mc and objdump level. I am not sure if we also need this in the disassembler driver (as in any case the output of this driver will be incorrect without having full semantics).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filters out empty segments from the specification. An empty segment
breaks, in particular, the Primus loader which treats it as a segment
that covers all addresses (an appropriate assert is added to make it
easier to discover such issues in the future).
Thanks @anwarmamat for reporting the issue.