-
Notifications
You must be signed in to change notification settings - Fork 279
Legacy floating point lifter #1255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Legacy floating point lifter #1255
Conversation
This is basically just the patch that @ivg formulated, but I have with proper authority edited out the notices that this is proprietary code. I added in a couple fixes, but there's possibly still more to be made before all this is really working. (There's definitely still issues in the Mayhem code on our side that's using this FP lifter, that are blocking me from confirming that stuff largely works as intended.) |
(Side note: Thanks for all the help Ivan! I've been working off a fork with this patch already applied, so, there's no pressure from our side to merge quickly. This PR is being issued right now because I was just informed that there was value in having all this out in public sooner rather than later.) |
Portions of this code that were formerly ForAllSecure proprietary are hereby released under the terms of the MIT license.
Not compatible with BAP FPU emu.
40258da
to
ff5c66d
Compare
I will add tests on Monday and will merge it then. Thanks! |
FWIW: There's some critical bug fixes to the x87 semantics that I'm working on, but, since the test added here seems to be SSE then that might work fine. I feel like it'll be most efficient if I hold off on submitting my fixes until I've got a full "working run" of the thing I'm trying to test right now (that way I can validate that my fixes are actually an improvement 😛), but @ivg what would you prefer between:
|
Portions of this code that were formerly ForAllSecure proprietary
are hereby released under the terms of the MIT license.