prints only code regions, use sections for names #1235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes BinaryAnalysisPlatform#1145 and makes disassembly printing more robust and more in line with the disassembler implementation. Background. When `-dasm` is specified we're iterating over sections and print subroutines that belong to that sections. Since sections in general can overlap we have duplicating outputs. This approach followed the old implementation of the disassembler that indeed was disassembling each section. However, at some point of time we switched to the code-region abstraction. Code regions do no overlap and are guaranteed to contain code. Now it is time to update the print plugin and also iterate over code regions. We still use sections for names but do not skip a region if there is no section (we just make up a bogus name). That makes printing more resilent to various custom loaders that might not provide sectioning information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1145 and makes disassembly printing more robust and
more in line with the disassembler implementation.
Background. When
-dasmis specified we're iterating over sectionsand print subroutines that belong to that sections. Since sections in
general can overlap we have duplicating outputs. This approach
followed the old implementation of the disassembler that indeed was
disassembling each section. However, at some point of time we switched
to the code-region abstraction. Code regions do no overlap and are
guaranteed to contain code. Now it is time to update the print plugin
and also iterate over code regions. We still use sections for names
but do not skip a region if there is no section (we just make up a
bogus name). That makes printing more resilent to various custom
loaders that might not provide sectioning information.