makes Knowledge.run more efficeint, bumps version #1024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Knowlege.run was computing every possible slot of a value, to ensure that all stored computations are triggered. However, for classes that have a lot of slots it was unnecessary slow, especially when none of those slots are having any stored computations. A simple fix, is to ignore slots without stored procedures turns out int x4 improvement of the run function for the program class. It doesn't affect the disassemble commmand, which wasn't using the run command, but affects `mc` and `objdump` which were using it.
gitoleg
approved these changes
Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Knowlege.run was computing every possible slot of a value, to ensure that all stored computations are triggered. However, for classes that have a lot of slots it was unnecessary slow, especially when none of those slots are having any stored computations.
A simple fix, is to ignore slots without stored procedures turns out int x4 improvement of the run function for the program class. It doesn't affect the disassemble command, which wasn't using the run command, but affects
mcandobjdumpwhich were using it.