Support Python 3.10 #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Importing the Iterable, Sequence, and Mapping ABCs directly from collections was deprecated in Python 3.3 and the aliases were removed in Python 3.10. Attempt to import from the new location, but if it fails because the current Python is older than 3.3, fall back to the old location.
|
Thanks! Yes, back in the day it was the intent. I don't know how valid it is nowadays, but let's keep it as you propose. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing the
Iterable,Sequence, andMappingABCs directly fromcollectionswas deprecated in Python 3.3 and the aliases were removed in Python 3.10.Based on other indications in this repository, I believe that the intent is still to support Python 2.7, so this PR attempts to import from the new location, but if it fails because the current Python is older than 3.3, falls back to the old location. If that's not the intent, I can remove these fallbacks.