Skip to content

fix(Matches): Correctly match Booleans: GET converts them to 0 and 1 #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2025

Conversation

arthurkirkosa
Copy link
Collaborator

No description provided.

@arthurkirkosa arthurkirkosa requested a review from binaryk June 6, 2025 12:06
Copy link

what-the-diff bot commented Jun 6, 2025

PR Summary

  • Enhancement to MatchFilter
    The MatchFilter has been improved by altering the way it treats '0' and 'false'. Now it regards '0' as a falsy value, similar to 'false'.

  • Introduction of New Test Method
    A new test method named test_can_match_boolean has been incorporated. This helps validate the process of filtering based on a boolean field is_active in our PostRepository.

  • Upgraded PostRepository
    The PostRepository has been augmented by adding an extra condition for matching is_active as a boolean filter. This has been added to the $match array, increasing our filtering options.

  • Expanded PostRepository Fields
    The fields() method of our PostRepository is now richer with the addition of is_active field to the returned fields.

  • Consistence in Instantiation
    The procedure for creating instances of actions and getters in the PostRepository has been updated for consistency. We now use parentheses throughout the process.

@binaryk binaryk merged commit 21bedd7 into 9.x Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants