Skip to content

fix(Search): Correctly search for strings with quotes and double quotes #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

arthurkirkosa
Copy link
Collaborator

No description provided.

Copy link

what-the-diff bot commented Feb 25, 2025

PR Summary

  • Enhanced Security in Search Query
    The search query code in SearchableFilter.php has been updated to increase security and safeguard against potential SQL injection attacks. This has been achieved by modifying the search clause to use parameter binding.

  • Improved Test Coverage
    A new test case has been added in RepositorySearchServiceTest.php to verify that the search functionality is working as expected when encountering strings with quotes and double quotes. This allows for more thorough testing and ensures that the search feature behaves consistently across different cases, even when special characters or different casing is used.

@binaryk binaryk merged commit 0271556 into 9.x Feb 25, 2025
@arthurkirkosa arthurkirkosa deleted the fix-search branch February 25, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants