Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: between combinator captures inner and outer results #146

Merged
merged 2 commits into from
Jul 23, 2022
Merged

feat: between combinator captures inner and outer results #146

merged 2 commits into from
Jul 23, 2022

Conversation

Bikossor
Copy link
Owner

Closes #145

@Bikossor Bikossor added enhancement New feature or request core: combinators Anything related to combinators labels Jul 23, 2022
@Bikossor Bikossor self-assigned this Jul 23, 2022
@Bikossor Bikossor linked an issue Jul 23, 2022 that may be closed by this pull request
between should capture inner and outer results #145
Closed
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2022 •
edited
Loading

Codecov Report

Merging #146 (885b2b3) into main (35a034e) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #146   +/-   ##
=======================================
  Coverage   97.88%   97.88%           
=======================================
  Files          19       19           
  Lines         189      189           
  Branches       29       29           
=======================================
  Hits          185      185           
  Misses          4        4
Impacted Files Coverage Δ
src/combinators/between.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35a034e...885b2b3. Read the comment docs.

@Bikossor Bikossor merged commit b379595 into main Jul 23, 2022
@Bikossor Bikossor deleted the 145-between-should-capture-inner-and-outer-results branch July 23, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Bikossor Bikossor

Labels
core: combinators Anything related to combinators enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

between should capture inner and outer results
2 participants
@Bikossor @codecov-commenter