agruminolemon board definition fixes

[d-a-v]

removed .orig files
removed some menu entries

Can you please try this menu and tell what's wrong or missing ?

[d-a-v]

specifically:

• what is the reset method ?
• flash frequency ?
• other specifics or hardcoded entries ?

You can try this pull request by downloading this file boards.txt

[d-a-v]

You defined a variant but there's no file, I'm adding one.
How do you want to name your GPIO ?

example with wemos d1 mini (variants/d1_mini/)
what names for the GPIO ?
what value for the builtin-led ? another one like in variant/nodemcu ?

#ifndef LED_BUILTIN
#define LED_BUILTIN 2
#endif
#define LED_BUILTIN_AUX 16

d1_mini:

#ifndef Pins_Arduino_h
#define Pins_Arduino_h

#define PIN_WIRE_SDA (4)
#define PIN_WIRE_SCL (5)

static const uint8_t SDA = PIN_WIRE_SDA;
static const uint8_t SCL = PIN_WIRE_SCL;

#define LED_BUILTIN 2

static const uint8_t D0   = 16;
static const uint8_t D1   = 5;
static const uint8_t D2   = 4;
static const uint8_t D3   = 0;
static const uint8_t D4   = 2;
static const uint8_t D5   = 14;
static const uint8_t D6   = 12;
static const uint8_t D7   = 13;
static const uint8_t D8   = 15;
static const uint8_t RX   = 3;
static const uint8_t TX   = 1;

#include "../generic/common.h"

#endif /* Pins_Arduino_h */

[d-a-v]

About this comment, esp8266#7883 (comment)
You need to get the latest master of the core, you seem to have an older version
(git pull remote-name master)

[Bighoneypot]

specifically:

• what is the reset method ?
• flash frequency ?
• other specifics or hardcoded entries ?

You can try this pull request by downloading this file boards.txt

Built in led 2
CPU frequency 80Mhz and 160Mhz
Flash size 2MB (FS:none OTA:~1008KB)

GPIO are hardcoded into our libraries (only 2 Gpio available and I2C)

[d-a-v]

GPIO are hardcoded into our libraries (only 2 Gpio available and I2C)

What are they and their name ?

[d-a-v]

Flash size 2MB (FS:none OTA:~1008KB)

pushed.

The boards.txt file link above is always valid, you can re-download it and try.

[Bighoneypot]

Ok, perfect

[Bighoneypot]

I understand

[d-a-v]

How should the variant file be modified ?

https://github.com/d-a-v/Arduino/blob/bhp/variants/agruminolemonv4/pins_arduino.h

[Bighoneypot]

Come dovrebbe essere modificato il file variante?

https://github.com/dav/Arduino/blob/bhp/variants/agruminolemonv4/pins_arduino.h

How should the variant file be modified ?

https://github.com/d-a-v/Arduino/blob/bhp/variants/agruminolemonv4/pins_arduino.h

// PINOUT Agrumino Implemented
#define PIN_SDA 2 // [X] BOOT: Must be HIGH at boot
#define PIN_SCL 14 // [X]
#define PIN_PUMP 12 // [X]
#define PIN_BTN_S1 4 // [X] Same as Internal WT8266 LED
#define PIN_USB_DETECT 5 // [X]
#define PIN_MOSFET 15 // [X] BOOT: Must be LOW at boot
#define PIN_BATT_STAT 13 // [X]
#define PIN_LEVEL 0 // [ ] BOOT: HIGH for Running and LOW for Program

[Bighoneypot]

I don't have understand this ......
You can try this pull request by downloading this file boards.txt

[Bighoneypot]

yes

[d-a-v]

I don't have understand this ......

The link is copied here. The content is updated at every pushed.
boards.txt: https://raw.githubusercontent.com/d-a-v/Arduino/bhp/boards.txt
variant file: https://raw.githubusercontent.com/d-a-v/Arduino/bhp/variants/agruminolemonv4/pins_arduino.h

[Bighoneypot]

About this comment, esp8266#7883 (comment)
You need to get the latest master of the core, you seem to have an older version
(git pull remote-name master)

Now you see if the current version is latest version?

[Bighoneypot]

I don't have understand this ......

The link is copied here. The content is updated at every pushed.
boards.txt: https://raw.githubusercontent.com/d-a-v/Arduino/bhp/boards.txt
variant file: https://raw.githubusercontent.com/d-a-v/Arduino/bhp/variants/agruminolemonv4/pins_arduino.h

but now I have to copy these files to my repository and then do a push

[d-a-v]

Now you see if the current version is latest version?

It seems to be OK

but now I have to copy these files to my repository and then do a push

No, you can click on "merge pull request", then on your computer git pull <your-remote-name> master and you'll have them on your computer

[d-a-v]

And if that's OK, you can make a new pull request on esp8266/Arduino

[Bighoneypot]

Now you see if the current version is latest version?

It seems to be OK

but now I have to copy these files to my repository and then do a push

No, you can click on "merge pull request", then on your computer git pull <your-remote-name> master and you'll have them on your computer

I have send merge pull request

[d-a-v]

Are you OK with the menu ?

[d-a-v]

Bene!

Mind you :)

In french and Italian, this word has a totally different meaning :)

[Bighoneypot]

all right!! ;-) Il giorno mer 17 feb 2021 alle ore 14:40 david gauchard < notifications@github.com> ha scritto:

…

Bene! Mind you :) In french and Italian, this word has a totally different meaning :) — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIPMDFAI6AZ2PPJH7TR6XY3S7PBNLANCNFSM4XYEFJBA> .

-- *Foddis Gabriele* +393403394922