Add parse_variables_sheet function with validation#85
Merged
Conversation
yulric
commented
Oct 23, 2025
460ca75 to
7002ec1
Compare
7002ec1 to
93febc6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the
parse_variables_sheet()function that validates variables sheets to ensure derived variables follow proper dependency rules.Key Features
DerivedVar::[cchs::age]is invalid)DerivedVar::[age, sex]✓DerivedVar::[var1, var2]✓cchs::ageor[age]✓variables_sheetassignedsuccess = FALSEand detailed error informationImplementation Details
New Files:
R/parse-variables-sheet.R- Main function and helper functionstests/testthat/test-parse-variables-sheet.R- Comprehensive test suiteHelper Functions:
.validate_variables_sheet_input()- Input validation (data frame, required columns).validate_derived_variables()- Core validation logic for derived variables.extract_feeder_variables()- Extracts variables fromDerivedVar::[...]syntax.is_database_column_reference()- Detectsdatabase::columnpatternTest Coverage
Comprehensive test suite with 12 test cases (6a through 6l):
pbc_variables.csv)All 30 tests passing ✓
Test plan
rig run -r 4.3.2 -e "devtools::test(filter = 'parse-variables-sheet')"devtools::document()pbc_variables.csv)🤖 Generated with Claude Code