Merged
Conversation
number of cigs per month wasn't being converted to packeyars per month, which is done by dividing by 20
The test case and expected values are stored in the `pack_years.csv` file It uses a newly added function called `test_derived_function` to run the expectations. This function can also be used by other functions that want to use the same workflow for testing Added instructions for using the new `test_derived_function` in a README.md file
Contributor
|
@StaceyFisher the latest commit adds a test for the "former daily, current occasional" scenario. Can you take a look and let |
yulric
approved these changes
Apr 19, 2025
Contributor
|
Looks good. I'll merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Number of cigs per month wasn't being converted to packyears per month for current occasional, former daily smokers, which is done by dividing by 20. Thanks to @reikookamoto for finding this bug!