-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V1.1.0 #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@DougManuel noticed some typos on a quick scan. Also in the ERD - Sample table has a typo which has 'ID' instead of 'sampleID'
Ontario Template based on ODM v1.0. Includes some validation rules
…rated using snakecase Sentence for english and deepl.com for french.
…ter information not being auto generated.
added in tables to help generate metadata
DougManuel
requested review from
hswerdfe,
jeandavidt,
NielsNicolai and
vipileggi
March 12, 2021 22:54
vipileggi
reviewed
Mar 13, 2021
vipileggi
reviewed
Mar 13, 2021
vipileggi
reviewed
Mar 13, 2021
vipileggi
reviewed
Mar 13, 2021
- New `porpVar`: Proportion of variant in sample. | ||
- `SiteMeasure` table, `type` variable | ||
- `wwBOD5c`, 5 day biochemical oxygen demand | ||
- `wwPtot`, Total phosphates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MECP lab typically measures total phosphorous (TP) wwTP
; but this is fine also but not too common from my experience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to discuss
vipileggi
reviewed
Mar 13, 2021
vipileggi
reviewed
Mar 13, 2021
vipileggi
reviewed
Mar 13, 2021
hswerdfe
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #59, #84, #90, #92, #93, #96, #97, #99, #102, #103, #104, #113, #114, #116.
Also see changelog.
Before merging to main: