Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.1.0 #117

Merged
merged 73 commits into from
Mar 15, 2021
Merged

V1.1.0 #117

merged 73 commits into from
Mar 15, 2021

Conversation

DougManuel
Copy link
Contributor

@DougManuel DougManuel commented Mar 12, 2021

Addresses: #59, #84, #90, #92, #93, #96, #97, #99, #102, #103, #104, #113, #114, #116.

Also see changelog.

Before merging to main:

  • @hswerdfe volunteered to clean-up merge conflict with CSV.
  • update changelog.
  • check ERD and SQL reflects model.

vipileggi and others added 30 commits January 31, 2021 17:58
@DougManuel  noticed some typos on a quick scan. Also in the ERD - Sample table has a typo which has 'ID' instead of 'sampleID'
Ontario Template based on ODM v1.0. Includes some validation rules
…rated using snakecase Sentence for english and deepl.com for french.
added in tables to help generate metadata
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
- New `porpVar`: Proportion of variant in sample.
- `SiteMeasure` table, `type` variable
- `wwBOD5c`, 5 day biochemical oxygen demand
- `wwPtot`, Total phosphates
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MECP lab typically measures total phosphorous (TP) wwTP; but this is fine also but not too common from my experience.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to discuss

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@DougManuel
Copy link
Contributor Author

There are a few open issues. I am not sure if they just need to be closed or still work to do.

#101, #106, #112, #113.

@hswerdfe hswerdfe merged commit 31accfd into main Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants