Skip to content

Auto-focus keyboard in GoToPage dialog #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hassan-Nisar-Ch wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Auto-focus keyboard in GoToPage dialog #61

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fda132b
Fix invisible text cursor in FindBar on dark background
Hassan-Nisar-Ch Oct 6, 2025
aeda95f
Auto-focus and show keyboard in GoToPage dialog
Hassan-Nisar-Ch Jan 26, 2026
8f5acb9
Merge branch 'Bhuvaneshw:main' into feature-improve-pdf-toolbar
Hassan-Nisar-Ch Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions compose-ui/src/main/java/com/bhuvaneshw/pdf/compose/ui/PdfToolBar.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1058,14 +1058,20 @@ private fun ZoomDialog(pdfState: PdfState, onDismiss: () -> Unit) {
@Composable
private fun GoToPageDialog(pdfState: PdfState, onDismiss: () -> Unit) {
var pageNumber by remember { mutableStateOf("") }
val focusRequester = remember { FocusRequester() }
val keyboard = LocalSoftwareKeyboardController.current

val select: () -> Unit = {
pageNumber.toIntOrNull()?.let { pdfState.pdfViewer?.goToPage(it) }
keyboard?.hide()
onDismiss()
}

AlertDialog(
onDismissRequest = onDismiss,
onDismissRequest = {
keyboard?.hide()
onDismiss()
},
title = {
Text(
text = "Go to page",
Expand All @@ -1074,7 +1080,12 @@ private fun GoToPageDialog(pdfState: PdfState, onDismiss: () -> Unit) {
)
},
confirmButton = { TextButton(onClick = select) { Text("Go") } },
dismissButton = { TextButton(onClick = onDismiss) { Text(text = "Cancel") } },
dismissButton = {
TextButton(onClick = {
keyboard?.hide()
onDismiss()
}) { Text("Cancel") }
},
text = {
BasicTextField(
value = pageNumber,
Expand All @@ -1092,7 +1103,8 @@ private fun GoToPageDialog(pdfState: PdfState, onDismiss: () -> Unit) {
cursorBrush = SolidColor(MaterialTheme.colorScheme.onBackground),
modifier = Modifier
.fillMaxWidth()
.padding(horizontal = 6.dp),
.padding(horizontal = 6.dp)
.focusRequester(focusRequester),
decorationBox = { textField ->
Box(Modifier.fillMaxWidth()) {
textField()
Expand All @@ -1112,6 +1124,13 @@ private fun GoToPageDialog(pdfState: PdfState, onDismiss: () -> Unit) {
)
}
)

LaunchedEffect(focusRequester) {
// Add a small delay to ensure the text field is composed and ready for focus
delay(100)
Copy link
Owner

@Bhuvaneshw Bhuvaneshw Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is delay the only way to do, have you tried any other reliable ways?

focusRequester.requestFocus()
keyboard?.show()
}
}

@Composable
Expand Down