Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error while processing shader in mainline bevy #12

Closed
Shfty opened this issue Mar 4, 2023 · 2 comments
Closed

Error while processing shader in mainline bevy #12

Shfty opened this issue Mar 4, 2023 · 2 comments
Labels
upstream Issue lies with an upstream repository

Comments

@Shfty
Copy link
Collaborator

Shfty commented Mar 4, 2023

When using regular v0.9.1 instead of Shfty/bevy:early-shader-defs, Shaders fail to process - preventing their material from rendering - and print the following error:

ERROR bevy_render::render_resource::pipeline_cache: failed to process shader: This Shader's format does not support processing shader defs.

Upstream issue: bevy/#7771

@Shfty Shfty transferred this issue from Bevy-Rust-GPU/bevy-pbr-rust Mar 4, 2023
@Shfty Shfty added this to the Stable Release milestone Mar 4, 2023
@Shfty Shfty added the upstream Issue lies with an upstream repository label Mar 4, 2023
@Shfty
Copy link
Collaborator Author

Shfty commented Mar 20, 2023

A fix has been merged into bevy main, so this is no longer a blocker.

However, bevyengine/bevy#7903 remains underway, which is a nicer solution to the problem, and the one currently depended on by bevy-rust-gpu - will continue to work on it and close this issue once it's merged.

@Shfty
Copy link
Collaborator Author

Shfty commented Mar 24, 2023

Closing this in lieu of a new issue specific to the need for shader def access.

@Shfty Shfty closed this as completed Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream Issue lies with an upstream repository
Projects
None yet
Development

No branches or pull requests

1 participant