-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: YASNCB (Yet Another Strict Null Checks Branch) #1703
Draft
corasaurus-hex
wants to merge
73
commits into
dev
Choose a base branch
from
cora/yasncb
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
73 commits
Select commit
Hold shift + click to select a range
aa2250b
Fix nulls/undefineds and improve repl info parser for params
corasaurus-hex a697c11
Stop using deprecated function and use our own instead
corasaurus-hex 02d317d
Fix an undefined value in utilities
corasaurus-hex 02960ca
Help typescript out with some type assertions in cursor-doc model
corasaurus-hex 0f72124
Fix null checks for project-types
corasaurus-hex 9426650
Fix null checks for completion provider
corasaurus-hex c73129e
Fix nulls in src/connector.ts
corasaurus-hex 3dd6b85
Fix null in src/converters.ts
corasaurus-hex 6e6640f
Fix nulls in cursor-doc indent and improve performance
corasaurus-hex 5aad863
Fix nulls in clojure-lexer
corasaurus-hex 0510888
Fix nulls in lexer
corasaurus-hex 347e7eb
Fix nulls in paredit.ts
corasaurus-hex 2527798
Fix nulls for _rangesForSexpsInList
corasaurus-hex be6765b
Fix remaining nulls for token-cursor.ts
corasaurus-hex 46fa6ad
Fix more nulls in paredit
corasaurus-hex ff9f09d
Fix nulls in undo.ts
corasaurus-hex 6e17118
Fix types for evaluating custom snippets
corasaurus-hex 39c3208
Fix types in repl-session
corasaurus-hex e2622a2
Fix null checks for clojuredocs
corasaurus-hex 7f77027
Fix debugger-related null checks
corasaurus-hex 28cf0f3
Fix more null checks in the debugger
corasaurus-hex 25af9b9
Another null check issue fixed, this time in doc-mirror
corasaurus-hex 4043c42
Fix null check issues in src/evaluate.ts
corasaurus-hex 74ab8f9
Fix some null check issues in extension tests
corasaurus-hex 6a04743
Fix null check issues in src/extension.ts
corasaurus-hex b91edb1
Fix a ton of null check issues in extension.ts for highlighting
corasaurus-hex a58fbf1
Fix live-share.ts null check issues
corasaurus-hex 30cc621
Fix a number of strict null check issues in lsp code
corasaurus-hex 6e26d72
Fix null check issues in providers
corasaurus-hex 387326f
Fix strict null check issue in repl-history.ts
corasaurus-hex c8c7ee7
Fix strict null check issue in when-contexts.ts
corasaurus-hex cb079b5
Fix strict null check issues for src/connector.ts
corasaurus-hex 20d0f2c
Fix strict null check issues for src/evaluate.ts
corasaurus-hex 1cddd85
Fix strict null check issues for src/nrepl/bencode.ts
corasaurus-hex 49a0f0f
Fix strict null check issues for src/nrepl/connectSequence.ts
corasaurus-hex b9cdce3
Fix strict null check issues for src/nrepl/index.ts
corasaurus-hex d608036
Fix strict null check issues for src/nrepl/jack-in-terminal.ts
corasaurus-hex b33def4
Fix strict null check issues for src/nrepl/jack-in.ts
corasaurus-hex 2dc2abf
Fix strict null check issues for src/nrepl/project-types.ts
corasaurus-hex 407b589
Fix strict null check issues for src/nrepl/repl-start.ts
corasaurus-hex 5e2ed4b
Fix strict null check issues for src/paredit/extension.ts
corasaurus-hex 6ff6e9b
Fix strict null check issues for src/project-root.ts
corasaurus-hex e8c4cb1
Fix strict null check issues for src/providers/definition.ts
corasaurus-hex b6b8db4
Fix strict null check issues for src/providers/signature.ts
corasaurus-hex aea1267
Fix strict null check issues for src/refresh.ts
corasaurus-hex c6fd333
Fix strict null check issues for src/results-output/results-doc.ts
corasaurus-hex 8425e1a
Fix strict null check issues for src/statusbar.ts
corasaurus-hex c3735e3
Fix strict null check issues for src/testRunner.ts
corasaurus-hex 1cdcd92
Fix strict null check issues for src/util/cursor-get-text.ts
corasaurus-hex fcf14e0
Enable strict null checks for typescript
corasaurus-hex adfe62a
Run prettier formatter
corasaurus-hex b119164
Rename getSession => tryToGetSession and make another getSession
corasaurus-hex 5da7c79
Restore whitespace
corasaurus-hex ac8f195
Remove assertions that are no longer needed due to new function
corasaurus-hex c1417db
No need to set to a variable before use
corasaurus-hex f310e64
More formatting
corasaurus-hex 859a6bb
Minimize more changes to connector
corasaurus-hex 7ac6f57
Whoops, use a record type not a map type
corasaurus-hex 1e921d6
Ensure same behavior here
corasaurus-hex 61437fe
Split project root local fns into tryToGet + get
corasaurus-hex d0cd19c
Move undefined check closer to where it is needed
corasaurus-hex 0778866
Forgot a bang !
corasaurus-hex 857054d
Swap out use of regex for much faster substring search
corasaurus-hex 5106ee8
Use function instead of try + assert
corasaurus-hex 18d7761
Compare against the right types
corasaurus-hex 3d1aec3
Get rid of unused import
corasaurus-hex b83c26d
Move type checking functions out to an ns without vscode
corasaurus-hex 13d7e82
Fix some null checks
corasaurus-hex bc7fadd
Fix the token cursor genericized function
corasaurus-hex cd0d893
Reformat the tsconfig
corasaurus-hex 6414e32
Use prettier to format JSON files in the project
corasaurus-hex f5c1fbd
Debug lsp downloads
corasaurus-hex df16f82
Add some debugging so we can figure out why integration tests are
corasaurus-hex File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix nulls in undo.ts
- Loading branch information
commit ff9f09de42d7547a5d34c9e5b11aa0403b20e034
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More TypeScript silliness. The length check means pop will always work but TypeScript can't figure that out.