Support cljs-suitable by adding "enhanced-cljs-completion?" flag to the completion request

[alendit]

https://github.com/rksm/clj-suitable allows the user to inspect javascript runtime through nrepl autocompletion interface. For it to be activated the "complete" requests have to have the "enhanced-cljs-completion?": "t" specified.

You might also want to add an option to calva to activate this flag.

[PEZ]

Hello, I think that in current Calva this already happens. The flag is added in later cider-nrepl, iiaci. Anyway, we'll keep this open, because we should confirm it and also we should probably bump the dependencies and add these options, as you suggest.

[alendit]

When I type js/M in the current calva master while connected to a shadow-cljs nRepl, no completion appears (the completion works in other places). After I added the flag to the "complete" request in repl/index.ts, the javascript completion started working, so I assume the flag wasn't passed before.

[PEZ]

Ah, yes, of course! I have forgotten that Shadow brings in some of the dependencies itself. So then the upgrade I thought I had under control has happened anyway. Good catch. I'll add the flag!

[PEZ]

Please take #553 for a spin, @alendit . It's a bit unclear to me how to specify false with the flag, "f" didn't seem to cut it. I looked at how CIDER does it, and followed suit.

[alendit]

Your change looks good. I'm not sure how to specify false either, but the way you do it (just not send the attribute) is the way CIDER does it, too, so I'd go with that.

I'll close this issue.

[PEZ]

Cool. Thanks! FYI, this is released now, so should be working if you upgrade to latest Calva.