Custom repl commands show error if run from non-clojure file

[bpringe]

When running a custom repl command from a non-clojure file VS Code shows an error that the command resulted in an error. We should more gracefully handle this situation, maybe by informing the user that the commands can only be run from clojure files.

[PEZ]

Maybe not enable the command in non-clojure files? And also not enable any of the shortcuts in that case.

That would make it difficult to provoke this situation and we wouldn't need to handle it more gracefully. 😄

[bpringe]

That's arguably another way of handling it gracefully. 😄

[leifericf]

I see that this is already fixed and merged in this commit.

It checks the language identifier to enable the command (editorLangId == clojure).

But is "Run Custom REPL Command" supposed to work for ClojureScript? Currently, the command does not show up for ClojureScript files, but I'm unsure whether it should show up.

As far as I can tell from the documentation, Visual Studio Code does not have a Language Identifier for ClojureScript.

[leifericf]

Ah! Upon further inspection, I found this in calva/package.json:

    "languages": [
      {
        "id": "clojure",
        "aliases": [
          "Clojure",
          "clojure"
        ],
        "extensions": [
          ".clj",
          ".cljs",
          ".cljc",
          ".cljd",
          ".cljx",
          ".clojure",
          ".edn",
          ".joke",
          ".boot",
          ".bb",
          ".calva-repl"
        ],
        "configuration": "./language-configuration.json"
      }
    ]

Which includes the ClojureScript extension: .cljs

I suppose this implies that Calva does not need to distinguish between Clojure and ClojureScript?

[PEZ]

is "Run Custom REPL Command" supposed to work for ClojureScript?

Yes. You can configure custom commands to use the Clojure or ClojureScript REPL, or leave it at ”whatever is the current REPL”. Do you have a REPL connected when you test that?

I suppose this implies that Calva does not need to distinguish between Clojure and ClojureScript?

Calva actually distinguishes between Clojure and ClojureScript, even if VS Code only cares about ”clojure”.

[bpringe]

Seems this should have been closed after the merge. Please continue the conversation here if necessary, though.