Exception Response Codes #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When ActionDispatch::ExceptionWrapper is available, use it to grab the exception's status code, return a 500 otherwise. * Update show_error_page to accept the caught exception * Send show_error_page the exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've put together bobbrez/errorspike as an example. By just installing BetterErrors, any error response (i.e. ActiveRecord::RecordNotFound 404) are being set to 500 responses. This makes it difficult to debug asynchronous requests that expect proper error codes.
If
ActionDispatch::ExceptionWrapperis available, then use it to generate the exception code, otherwise continue issuing a 500.