Added broadcast events #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 20, 2023 20:50
This commit adds support for broadcast events to the events system. A new class `broadcast` has been added to the `events-default` plugin, which extends the `EventEmitter` class from the Node.js `events` module. The `broadcast` class has two methods: `onBroadcast` and `emitBroadcast`. These methods allow plugins to listen for and emit broadcast events, respectively. The `Events` class in the `events-default` plugin has been updated to include a `broadcast` property, which is an instance of the `broadcast` class. The `Events` class also has two new methods: `onBroadcast` and `emitBroadcast`, which delegate to the corresponding methods on the `broadcast` instance. The `IServiceEvents` interface has been updated to include two new methods: `onBroadcast` and `emitBroadcast`. The `ServiceEvents` interface has been renamed to ` feat(service): add support for broadcasting events This commit adds support for broadcasting events to the ServicesBase and RegisteredPlugin classes. The new methods added are onBroadcast and emitBroadcast. The onBroadcast method allows the service to listen to broadcasted events, while the emitBroadcast method allows the service to emit broadcasted events. The ServicesBase and RegisteredPlugin classes now have two new type parameters, onBroadcast and emitBroadcast, which are used to define the types of the onBroadcast and emitBroadcast methods. The ServicesClient class also has two new type parameters, onBroadcast and emitBroadcast, which are used to define the types of the onBroadcast and emitBroadcast methods in the referenced service. chore(base.ts): refactor setupServicePlugin method to include new events feat(events.ts): add onBroadcast and emitBroadcast methods to IServiceEvents refactor(services.ts): update generateEventsForService method signature to include new events feat(tests): add tests for broadcasting events in EventsBase class test(events): add test to ensure only one plugin receives an event test(events): add test to ensure events can be emitted to plugins with name defined test(events): add broadcast test to events-default plugin
This commit adds support for broadcast events to the events system. A new class `broadcast` has been added to the `events-default` plugin, which extends the `EventEmitter` class from the Node.js `events` module. The `broadcast` class has two methods: `onBroadcast` and `emitBroadcast`. These methods allow plugins to listen for and emit broadcast events, respectively. The `Events` class in the `events-default` plugin has been updated to include a `broadcast` property, which is an instance of the `broadcast` class. The `Events` class also has two new methods: `onBroadcast` and `emitBroadcast`, which delegate to the corresponding methods on the `broadcast` instance. The `IServiceEvents` interface has been updated to include two new methods: `onBroadcast` and `emitBroadcast`. The `ServiceEvents` interface has been renamed to ` feat(service): add support for broadcasting events This commit adds support for broadcasting events to the ServicesBase and RegisteredPlugin classes. The new methods added are onBroadcast and emitBroadcast. The onBroadcast method allows the service to listen to broadcasted events, while the emitBroadcast method allows the service to emit broadcasted events. The ServicesBase and RegisteredPlugin classes now have two new type parameters, onBroadcast and emitBroadcast, which are used to define the types of the onBroadcast and emitBroadcast methods. The ServicesClient class also has two new type parameters, onBroadcast and emitBroadcast, which are used to define the types of the onBroadcast and emitBroadcast methods in the referenced service. chore(base.ts): refactor setupServicePlugin method to include new events feat(events.ts): add onBroadcast and emitBroadcast methods to IServiceEvents refactor(services.ts): update generateEventsForService method signature to include new events feat(tests): add tests for broadcasting events in EventsBase class test(events): add test to ensure only one plugin receives an event test(events): add test to ensure events can be emitted to plugins with name defined test(events): add broadcast test to events-default plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.