Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(prometheus - minor bug fix) - litellm_llm_api_time_to_first_token_metric not populating for bedrock models #7740

Merged
merged 7 commits into from
Jan 14, 2025

Conversation

ishaan-jaff
Copy link
Contributor

@ishaan-jaff ishaan-jaff commented Jan 13, 2025

(prometheus - minor bug fix) - litellm_llm_api_time_to_first_token_metric not populating for bedrock models

Screenshot 2025-01-13 at 7 39 28 AM

Cause of the issue ?

  • we were checking model_parameters["stream] in standard_logging_payload to confirm if we should emit time_to_first_token_metric
  • kwargs["stream"] was the location where we should have checked

Relevant issues

Type

🐛 Bug Fix
✅ Test

Changes

[REQUIRED] Testing - Attach a screenshot of any new tests passing locally

If UI changes, send a screenshot/GIF of working UI fixes

Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 2:46am

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@ishaan-jaff ishaan-jaff merged commit 9daa6fb into main Jan 14, 2025
32 checks passed
rajatvig pushed a commit to rajatvig/litellm that referenced this pull request Jan 16, 2025
…etric` not populating for bedrock models (BerriAI#7740)

* fix prometheus ttft

* fix test_set_latency_metrics

* fix _set_latency_metrics

* fix _set_latency_metrics

* fix test_set_latency_metrics

* test_async_log_success_event

* huggingface/mistralai/Mistral-7B-Instruct-v0.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant