fix(prompts): fix prompt info lookup and delete using correct IDs #19358
+315
−89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issues
Fixes Prompts UI bugs: "Prompt not found" and broken deletion logic.
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitCI (LiteLLM team)
Branch creation CI run
Link:
CI run for the last commit
Link:
Merge / cherry-pick CI run
Links:
Type
🐛 Bug Fix
Changes
This PR fixes two critical issues in the Prompts configuration endpoints related to ID handling (Base ID vs Versioned ID mismatch).
1. Fix "Prompt not found" error in UI
my_prompt) to lookup callbacks in the registry, but the registry keys are versioned IDs (e.g.,my_prompt.v1).prompt_spec.prompt_id(the resolved versioned ID).2. Fix Silent Failure on Prompt Deletion (Critical)
test.v1). However, the Postgres database stores prompts using the base ID (test) + a version column. This caused the DB deletion to fail silently (0 rows deleted).IN_MEMORY_PROMPTS.delete_manyquery.InMemoryPromptRegistry.delete_prompts_by_base_idhelper method to reliably clean up all versions of a prompt from memory.Verification
Tesing.mp4