[Feature] Auto Resolve Vector Store Embedding Model Config #18167
+251
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issues
The Milvus vector store requires these fields to be defined in the litellm_params: litellm_embedding_model and litellm_embedding_config.
Currently the UI allows the users to only choose an embedding model, but since we already have the config stored, we should automatically resolve the config for the user. This PR implements this feature
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitCI (LiteLLM team)
Branch creation CI run
Link: https://app.circleci.com/pipelines/github/BerriAI/litellm/52027
CI run for the last commit
Link: https://app.circleci.com/pipelines/github/BerriAI/litellm/52028
Merge / cherry-pick CI run
Links:
Type
🆕 New Feature
✅ Test
Changes
Now queries through test vector store no longer throw a 500 while using milvus:
