[Fix] Convert TypeError to BadRequestError for missing/invalid parameters #16994
+434
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Convert TypeError to BadRequestError for missing/invalid parameters
Relevant issues
Fixes #16993
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitType
🐛 Bug Fix
Changes
Problem
When calling LiteLLM API functions with missing or invalid parameters, error handling is inconsistent:
Solution
Added TypeError to BadRequestError conversion at two layers:
1. Core Library (
litellm/utils.py)@clientdecorator (both sync and async)r"missing (\d+ )?required positional argument[s]?:? '?([^']+)'?"kwargs.getinstead ofkwargs[])BadRequestErrorwith HTTP 400 status code and clear error message2. Proxy Layer (
litellm/proxy/route_llm_request.py)route_requestfunction_route_request_implin try-except block3. Test Coverage
Added comprehensive test suite:
Core library tests (
tests/test_litellm/test_parameter_validation_error.py): 5 test casesProxy tests (
tests/proxy_unit_tests/test_proxy_parameter_validation.py): 6 test casesTest Results
Core Library Tests - AFTER Implementation:
Proxy Tests - AFTER Implementation:
Impact
Files Changed
litellm/utils.py: Added TypeError handling in@clientdecoratorlitellm/proxy/route_llm_request.py: Added TypeError handling in route_requesttests/test_litellm/test_parameter_validation_error.py: New test file (5 tests)tests/proxy_unit_tests/test_proxy_parameter_validation.py: New test file (6 tests)