Skip to content

Add deployment annotations #11849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

InvisibleMan1306
Copy link
Contributor

Title

Add annotations to LiteLLM Deployment.

Relevant issues

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

I did not change any code just configurations for Helm chart.

  • I have Added testing in the tests/litellm/ directory, Adding at least 1 test is a hard requirement - see details
  • I have added a screenshot of my new test passing locally
  • My PR passes all unit tests on make test-unit
  • My PR's scope is as isolated as possible, it only solves 1 specific problem

Type

🆕 New Feature

Changes

Added annotations for Helm chart LiteLLM Deployment. Certain Kuberenetes tools work better with annotations on Deployments rather than Pods.

Copy link

vercel bot commented Jun 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2025 2:54pm

@CLAassistant
Copy link

CLAassistant commented Jun 18, 2025

CLA assistant check
All committers have signed the CLA.

@InvisibleMan1306
Copy link
Contributor Author

Testing

Ran tests to print out the helm chart for 3 different passed in values using the command:

helm template litellm-helm deploy/charts/litellm-helm -n litellm --values ~/scratchpad/litellm.yaml | yq 'select(.kind == "Deployment") | .metadata'

Where ~/scratchpad/litellm.yaml is a local helm values file and I filter the output to the Deployment metadata.

  1. Deployment annotations defined
    deploymentAnnotations:
      "reloader.stakater.com/auto": "true"
      something: else
    ➜ helm template litellm-helm deploy/charts/litellm-helm -n litellm --values ~/scratchpad/litellm.yaml | yq 'select(.kind == "Deployment") | .metadata'
    annotations:
      reloader.stakater.com/auto: "true"
      something: else
    name: litellm-helm
    labels:
      helm.sh/chart: litellm-helm-0.4.4
      app.kubernetes.io/name: litellm
      app.kubernetes.io/instance: litellm-helm
      app.kubernetes.io/version: "v1.50.2"
      app.kubernetes.io/managed-by: Helm
  2. Deployment annotations defined as empty dict
    deploymentAnnotations: {}
    ➜ helm template litellm-helm deploy/charts/litellm-helm -n litellm --values ~/scratchpad/litellm.yaml | yq 'select(.kind == "Deployment") | .metadata'
    annotations: {}
    name: litellm-helm
    labels:
      helm.sh/chart: litellm-helm-0.4.4
      app.kubernetes.io/name: litellm
      app.kubernetes.io/instance: litellm-helm
      app.kubernetes.io/version: "v1.50.2"
      app.kubernetes.io/managed-by: Helm
  3. Deployment annotations not defined
    ➜ helm template litellm-helm deploy/charts/litellm-helm -n litellm --values ~/scratchpad/litellm.yaml | yq 'select(.kind == "Deployment") | .metadata'
    annotations: {}
    name: litellm-helm
    labels:
      helm.sh/chart: litellm-helm-0.4.4
      app.kubernetes.io/name: litellm
      app.kubernetes.io/instance: litellm-helm
      app.kubernetes.io/version: "v1.50.2"
      app.kubernetes.io/managed-by: Helm

Copy link
Contributor

@ishaan-jaff ishaan-jaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ishaan-jaff ishaan-jaff merged commit 1d58fc5 into BerriAI:main Jun 20, 2025
6 checks passed
satendrakumar pushed a commit to satendrakumar/litellm that referenced this pull request Jul 24, 2025
* Add deployment annotations

* Correct the indent and simplify if 0 annotations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants