reformat Bonsai network response#1
Merged
BerndDoser merged 1 commit intoBerndDoser:masterfrom Sep 29, 2016
Merged
Conversation
Update network json response updated to new specification:
for any requests, responses should be formatted as
{"user_particles": [0, 0, 0, 0], "simulation_time": 89.4, "response": "release"}
{"user_particles": [0, 0, 0, 0], "simulation_time": 89.4, "response": "remove"}
{"user_particles": [0, 0, 0, 0], "simulation_time": 89.4, "response": "report"}
The "response" field reflects the request name that triggered the response.
Owner
|
Looks good, especially the user_particles as array is much better. Instead of the hard coded 4 we can use WOGManager::number_of_users. I change it after the merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Bernd,
I've changed the Bonsai network response format to reflect our current expectations: responses should always have the same format, just reflect the type of original request in their "response" field. Check whether you feel happy about the implementation. :-)
Update network json response updated to new specification:
for any requests, responses should be formatted as
{"user_particles": [0, 0, 0, 0], "simulation_time": 89.4, "response": "release"}
{"user_particles": [0, 0, 0, 0], "simulation_time": 89.4, "response": "remove"}
{"user_particles": [0, 0, 0, 0], "simulation_time": 89.4, "response": "report"}
The "response" field reflects the request name that triggered the response.