player: Ensure video retains consistent sizing#9
Merged
Conversation
This ensures that cycling between full screen and non-full screen does not cause any change of the positioning of the video nor its size. By removing the video element CSS in main.scss, we can additionally have a fully responsive video element that will be a nominal 600px for the majority of our video content. This can be explored later. Closes: AP-339
anarchivist
approved these changes
May 27, 2025
Member
anarchivist
left a comment
anarchivist
left a comment
There was a problem hiding this comment.
looks great. should we say in the commit message/PR description that this closes AP-339?
This ensures that the video viewport is fully responsive. Ref: AP-339, AP-340
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that cycling between full screen and non-full screen does not cause any change of the positioning of the video nor its size.
By removing the video element CSS in main.scss, we can additionally have a fully responsive video element that will be a nominal 600px for the majority of our video content. This can be explored later.