AP-335: Vendor MediaElement for full-screen Safari fix#8
Merged
Conversation
This is filed upstream with a pull request as [mediaelement#2995](mediaelement/mediaelement#2995) but until upstream can merge it and make a release, we vendor a copy with the fix applied. Closes: AP-335
Fixes: DEV-910 Related: DEV-909
awilfox
force-pushed
the
AP-335-vendor-mejs
branch
from
0aaec60 to
abb7e36
Compare
anarchivist
approved these changes
May 20, 2025
Member
anarchivist
left a comment
anarchivist
left a comment
There was a problem hiding this comment.
looks good to me! you can also revert 6499474 - they fixed the built versions of upstream dash.js so the old URLs resolve.
This reverts commit 6499474. Upstream dash.js has fixed their URL resolution, so this isn't needed any more. See-also: avplayer#8 Ref: AP-314
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is filed upstream with a pull request as mediaelement/mediaelement#2995 but until upstream can merge it and make a release, we vendor a copy with the fix applied.
Closes: AP-335