Skip to content

Remove vendored dependencies #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rouson merged 4 commits into from
Apr 20, 2023
Merged

Remove vendored dependencies #132

rouson merged 4 commits into from
Apr 20, 2023

Conversation

@rouson
Copy link
Collaborator

@rouson rouson commented Apr 20, 2023 •
edited
Loading

  1. Remove vendor/ subdirectory.
  2. Replace setup.sh script with a static fpm.toml.
  3. Update the README.md build/test instructions.

@rouson rouson removed the request for review from everythingfunctional April 20, 2023 02:10
@everythingfunctional
Copy link
Member

everythingfunctional commented Apr 20, 2023

You missed adding the fpm.toml file. I think it might be listed in the .gitignore. Other than that, seems like a good idea.

@rouson
Copy link
Collaborator Author

rouson commented Apr 20, 2023

You missed adding the fpm.toml file. I think it might be listed in the .gitignore. Other than that, seems like a good idea.

@everythingfunctional thanks for the quick review! I had just caught that. I had the fpm.toml file in the .gitignore. I removed it from there and committed the file.

@rouson rouson merged commit 0f99ebb into main Apr 20, 2023
@rouson rouson deleted the rm-caffeine branch April 20, 2023 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rouson @everythingfunctional