Finish C-interoperability and simplify nested associations #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit 1. Combines nested associate statements where possible, 2. Adds bind(C) the two remaining procedures in do_concurrent_m, 3. Makes the changes that bind(C) necessitates, including a. Switching to interoperable types and b. Switching functions to subroutines The previous functions had allocatable array results, whereas the Fortran 2018 standard clause 18.3.6 requires scalar function results for bind(C) functions.
This commit combines the do_concurrent_x and do_concurrent_speeds subroutines because the former simply copied data for use in the latter.
This commit adjusts the indentation in one procedure and removes a commented line of code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit
do_concurrent_*procedures into one,bind(C)to the two procedures indo_concurrent_mthat didn't have it,bind(C)necessitates, includinga. Switching to interoperable types and
b. Switching functions to subroutines
The previous functions had allocatable array results, whereas the Fortran 2018 standard clause 18.3.6 requires scalar function results for
bind(C)functions.This PR speeds up single-image runs about 33% and preserves the parallel scalability: