Implement image_index_with_team and this_image_with_{coarray,dim}, partial {image_index,num_images}_with_team_number #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Rebased to pick-up new CI |
Factor prif_image_index and use the same logic to implement prif_image_index_with_team
Merge the two loops, so we perform bounds-checking in the same pass with image computation. Insert return statements to potentially reduce branchiness
only supports team_number==-1 for the initial team and team number of the current team (no support for sibling teams)
only supports team_number==-1 for the initial team and team number of the current team (no support for sibling teams)
ktras
reviewed
May 14, 2025
Collaborator
ktras
left a comment
ktras
left a comment
There was a problem hiding this comment.
Looks good but I have a couple questions listed in comments on code.
bonachea
commented
May 14, 2025
Member
Author
bonachea
left a comment
bonachea
left a comment
There was a problem hiding this comment.
I've added responses to reviewer questions, please let me know if those satisfy your concerns.
Ready for next round of review.
bonachea
commented
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a complete implementation of
prif_image_index_with_team, by factoring the existingprif_image_indeximplementation.Adds a complete implementation of
prif_this_image_with_{coarray,dim}Adds partial implementations for
prif_{image_index,num_images}_with_team_number(for the cases that can be implemented efficiently/scalably).Fixes #214
Fixes #215
Fixes #227