Misc compiler warning fixes #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some examples:
```
test/main.F90:91:74:
91 | individual_tests = [individual_tests, a00_caffeinate_caffeinate()]
| ^
Warning: 'MEM[(struct test_item_t[1] *)_1380][0]' may be used uninitialized [-Wmaybe-uninitialized]
Warning: Unused parameter 'initiation_success' declared at (1) [-Wunused-parameter]
test/prif_this_image_test.F90:28:58:
28 | image_numbers = [(merge(0, me, me/=i), i = 1, ni)]
| ^
Warning: 'image_numbers.offset' is used uninitialized [-Wuninitialized]
test/prif_this_image_test.F90:23:48:
23 | integer, allocatable :: image_numbers(:)
| ^
note: 'image_numbers' declared here
```
```
././src/caffeine/prif_private_s.F90:283:47:
283 | integer(int_ptr_check), parameter :: unused = 0_int_ptr_check
| 1
Warning: Unused parameter 'unused' declared at (1) [-Wunused-parameter]
```
Use a real (dynamic) assertion instead.
```
././src/caffeine/coarray_queries_s.F90:64:20:
64 | image_index = 1 + sub(1) - coarray_handle%info%lcobounds(1)
| 1
Warning: Possible change of value in conversion from INTEGER(8) to INTEGER(4) at (1) [-Wconversion]
././src/caffeine/coarray_queries_s.F90:71:21:
71 | prior_size = prior_size * (coarray_handle%info%ucobounds(dim-1) - coarray_handle%info%lcobounds(dim-1) + 1)
| 1
Warning: Possible change of value in conversion from INTEGER(8) to INTEGER(4) at (1) [-Wconversion]
././src/caffeine/coarray_queries_s.F90:72:22:
72 | image_index = image_index + (sub(dim) - coarray_handle%info%lcobounds(dim)) * prior_size
| 1
Warning: Possible change of value in conversion from INTEGER(8) to INTEGER(4) at (1) [-Wconversion]
```
Add explicit truncating integer conversions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some harmless but annoying compiler warnings throughout Caffeine encountered during development.
Here I'm deliberately ignoring the warnings currently issued by the collectives unit tests, which are resolved via complete rewrite in #158