Fix issue #163 #168
Merged
Fix issue #163 #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commmit fixes the caf_co_max and caf_co_min tests so that they pass for single-image runs.
This commit adds comments and renames variables to make the logic of the caf_co_min and caf_co_max tests more transparent.
bonachea
reviewed
Dec 28, 2024
Member
bonachea
left a comment
bonachea
left a comment
There was a problem hiding this comment.
This PR fixes test code that targets PRIF 0.4, and will be incompatible with PRIF 0.5 where the interfaces have been renamed to prif_co_{min,max}_character and require kind=c_char.
PR #158 contains the work-in-progress to convert the collectives implementation and this same test code to PRIF 0.5, and this PR will conflict with that work.
That being said, I have no objection to merging this as a near-term fix until the PRIF 0.5 collectives work is ready.
bonachea
approved these changes
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
prif_co_minandprif_co_maxtests,prif_co_minandprif_co_maxtests, andwritestatement inprif_stop_integer.