Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle touch events correctly inside ScrollView #2

Conversation

andgeno
Copy link

@andgeno andgeno commented Jan 6, 2017

Working solution for issue #1

@BeppiMenozzi
Copy link
Owner

Thank you very much! This fixes a problem, but evidentiated to me another problem, that comes with BalloonPopups: they don't scroll with the ScrollView, expecially when they are permanent. I'll merge this anyway, and see if I can fix the other one :)

@BeppiMenozzi BeppiMenozzi merged commit 89506ca into BeppiMenozzi:master Jan 9, 2017
@andgeno
Copy link
Author

andgeno commented Jan 9, 2017

You're welcome. I have made a couple more additions in the meanwhile. Since I'm on a dead line with my project at the moment, I can't tell you when I find the time to create PRs for them.

My others additions are:

  • Support fractions (2 digits at the moment)
  • Support positive and negative range with zero centered at the top incl. proper half-rendering of either side for markers
  • Added "smartmode" for when moving current value from negative to positive value (or vice versa), an artifical step to zero will be made for easy value resetting (optionally keeps fractions or removes them).
  • Added/improved click listener to only react on clicks inside knob circle area
  • Improved rendering performance (significantly)

@andgeno
Copy link
Author

andgeno commented Jan 9, 2017

Oh and about the balloon popup issue. You're right. I didn't need it so I disabled it for now in my use-case. Sorry about that. ;-)

@BeppiMenozzi
Copy link
Owner

:-) Things are there to be enabled and disabled!
Please, if you can, let me know if you happen to use it in an app!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants