Bug fix release 4.1.1 #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm so stupid. I made a mistake in the format. sorry!
It is not mandatory to use WorldBorderAPI, so it should be clear for the user that they have a choice besides integrating with it.
* Unify wording of WBAPI-excluded configs * Add `show-particles` to README * Clarify message for show-particles setting
* Rename PlayerBorder.barrier to show * Move player event handlers to PlayerListener * Remove PlayerBorder * Implement PerPlayerBorderProxy Currently defaulting to Customer (non-wbapi) border * Add BorderTypeCommand * Create BorderType * Add messages to BorderTypeCommand * Prepare PerPlayerBorderProxy for handling edge cases The user may not have a border type set, then we return with the default. The user's border type may be unavailable now for two reasons: 1. Border type has been disabled after a server/plugin restart 2. Border type is obsolete and does not exist anymore (forward compatibility). * Fix message reference at BorderTypeCommand * Use null for missing wbapiBorder It is fine since it is never used * Avoid wbapi "border show" spam on player move * At command, replace args.isEmpty() with size() != 1 To also show help if more parameters are passed than necessary * Small refactor * Fix set-type permission in addon.yml * Update README Co-authored-by: tastybento <tastybento@users.noreply.github.com>
* Remove commented code * Purify config.yml As I see, this is just another place to duplicate our settings, documentation and changes to these. This file is generated if missing. * Cleanup Settings.java This is another place where we duplicated documentation. * Purify README.md * Fix failing test: testIsUseWbapi * Revert "Cleanup Settings.java" This reverts commit f8e931c. * Format Settings.java and add documentation link * Regenerate config.yml
Using Collection.size() to test for emptiness works, but using Collection.isEmpty() makes the code more readable and can be more performant. The time complexity of any isEmpty() method implementation should be O(1) whereas some implementations of size() can be O(n). In this case, it's not a big deal, just a code smell.
Co-authored-by: Alunite? <xcionsspro30@gmail.com>
Co-authored-by: VerusBungee <gangmastergriefing@gmail.com>
* Translate zh-TW.yml via GitLocalize * Update zh-TW.yml Co-authored-by: davgo0103 <davvgo@gmail.com> Co-authored-by: tastybento <tastybento@users.noreply.github.com>
* Translate ko.yml via GitLocalize * Update ko.yml Co-authored-by: chickiyeah <ruddls030@naver.com> Co-authored-by: tastybento <tastybento@users.noreply.github.com>
* Translate pl.yml via GitLocalize * Update pl.yml Co-authored-by: PICIGIT <piotrp.p@wp.pl> Co-authored-by: tastybento <tastybento@users.noreply.github.com>
* Switch to use new Bukkit / Paper WorldBorder API
Vanilla World Border automatically converts coordinates by dimension multiplayer. So in the nether it is required to counter it with extra processing. Co-authored-by: BuildTools <unconfigured@null.spigotmc.org>
…ommand. Requested by #87
Requested by #86
This could lead to a showing up a virtual border where it should not be.
Co-authored-by: Marmur2020 <marmur2020@gmail.com>
Co-authored-by: wiktorm12 <wiktorm12@gmail.com>
* Translate fr.yml via GitLocalize * Translate fr.yml via GitLocalize Co-authored-by: HipppB <hippolyte.bach@eleve.isep.fr> Co-authored-by: organizatsiya <organizatsiya.wildguns@gmail.com>
Co-authored-by: 0x4096 <rjansengd@gmail.com>
* Translate es.yml via GitLocalize * Translate es.yml via GitLocalize Co-authored-by: roy0510 <roytacruz@gmail.com> Co-authored-by: plebexer <plebexer@gmail.com>
Changed the permission for the type command to "border.type" instead of "border.set-type" because with the hyphen in it, Bukkit always grants the permission for some reason. Addresses #96
Had to make some classes non-final so they can be mocked.
) Redoes the config.yml as well. Adds test classes. Relates to #97
* Use default settings in config if player does not have permissions. Redoes the config.yml as well. Adds test classes. Relates to #97 * Remove unused import. * Adds offset config to enable border to be bigger than protection range #75 Adds test class for ShowBarrier. * Added ShowVirtualWorldBorder test class #75
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.