Skip to content

Commit

Permalink
Relax dependency of HF hub being < v0.10
Browse files Browse the repository at this point in the history
That restriction was a short term solution because we thought we could
make v0.10 work with a few changes. However, that's not the case because
of a bug in HF hub model cards on Windows. This requires a bugfix
release before it would be fixed.

In the meantime, we should allow users to install v0.10, since there is
no technical reason not to use it. The only annoyance is that users will
get FutureWarnings.

For CI, we filter out corresponding FutureWarnings for the time being.
Once the HF hub bug is fixed, we can proceed with skops-dev#162 and remove the
filter.
  • Loading branch information
BenjaminBossan committed Oct 4, 2022
1 parent e4efbc8 commit ab77b47
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 2 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ profile = "black"
filterwarnings = [
"error::DeprecationWarning",
"error::FutureWarning",
# TODO: remove line below once we changed hub calls to use use_auth_token
"ignore:Deprecated argument\\(s\\) used in 'model_info':FutureWarning",
]
markers = [
"network: marks tests as requiring internet (deselect with '-m \"not network\"')",
Expand Down
3 changes: 2 additions & 1 deletion skops/_min_dependencies.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
# "tomli": ("1.1.0", "install", "python_full_version < '3.11.0a7'"),
dependent_packages = {
"scikit-learn": ("0.24", "install", None),
"huggingface_hub": ("0.9.0rc3,<0.10.0rc0", "install", None),
# TODO: remove '<0.12.0rc0' once we changed hub calls to use use_auth_token
"huggingface_hub": ("0.9.0rc3,<0.12.0rc0", "install", None),
"modelcards": ("0.1.6", "install", None),
"tabulate": ("0.8.8", "install", None),
"pytest": (PYTEST_MIN_VERSION, "tests", None),
Expand Down

0 comments on commit ab77b47

Please sign in to comment.