Conversation
dilpath
approved these changes
Oct 15, 2024
Collaborator
dilpath
left a comment
dilpath
left a comment
There was a problem hiding this comment.
Thanks, should we delete the fallback version and make a GitHub release immediately after merging this, with the appropriate version format?
dilpath
reviewed
Oct 15, 2024
Member
Author
Good to make a release, but no need to remove the fallback version. This will just be ignored then. Update: Created a compatible tag for the previous release and removed the fallback. |
dweindl
force-pushed
the
setuptoolsscm
branch
2 times, most recently
from
6680903 to
76b2ebd
Compare
Removes some extra `build-system.requires` entries.
dweindl
force-pushed
the
setuptoolsscm
branch
from
76b2ebd to
980047f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes some extra
build-system.requiresentries.So far, repository versions were date-based (well, there was only one, v20230717). The Python package had a constant version number
0.0.0a1.To work well with the default setuptools_scm schema, future releases should ideally use
vYYYY.MM.DDtags.The Python package will then also have the same version as the benchmark collection as such.