Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add edits for tvOS and iOS #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add edits for tvOS and iOS #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ProceduralDungeon.uplugin
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,10 @@
"Type": "Runtime",
"LoadingPhase": "PreDefault",
"WhitelistPlatforms": [
"Win64"
"Win64",
"Mac",
"IOS",
"TVOS"
]
},

Expand All @@ -29,7 +32,10 @@
"Type": "Editor",
"LoadingPhase": "Default",
"WhitelistPlatforms": [
"Win64"
"Win64",
"Mac",
"IOS",
"TVOS"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are iOS and tvOS needed for the Editor module?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking the same thing, I can remove it and test it out again.

]
}
]
Expand Down
2 changes: 1 addition & 1 deletion Source/ProceduralDungeon/Private/DungeonGenerator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ void ADungeonGenerator::CreateDungeon()
if (!HasAuthority())
return;

int TriesLeft = MaxTry;
int TriesLeft = 500;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why MaxTry should be removed to compile on iOS?

bool ValidDungeon = false;

// generate level until IsValidDungeon return true
Expand Down
2 changes: 1 addition & 1 deletion Source/ProceduralDungeon/Public/DungeonGenerator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ class PROCEDURALDUNGEON_API ADungeonGenerator : public AActor
uint32 Seed;

static uint32 GeneratorCount;
static const uint32 MaxTry {500};
// static const uint32 MaxTry {500};
static const uint32 MaxRoomTry {10};

FRandomStream Random;
Expand Down