Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #149 #150

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Fix for #149 #150

merged 1 commit into from
Oct 12, 2023

Conversation

rhammen
Copy link
Contributor

@rhammen rhammen commented Oct 12, 2023

Fix for #149

@rhammen rhammen mentioned this pull request Oct 12, 2023
Closed
BenPru
BenPru approved these changes Oct 12, 2023
View reviewed changes
Copy link
Owner

@BenPru BenPru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit_of_measurement is the default entity description property.
Approve without depper check.

@BenPru BenPru merged commit cbb9223 into BenPru:main Oct 12, 2023
@rhammen rhammen mentioned this pull request Oct 12, 2023
Closed
@rhammen
Copy link
Contributor Author

rhammen commented Oct 12, 2023

FYI: The ClimateEntity and the Water Heater Entity do not specify (do not allow) a "unit_of_measurement " property. Both do however allow the "temperature_unit" property, the Climate Entity even requires it. That is why I changed "unit_of_measurement" --> "temperature_unit"
This fixed a problem visible in the UI. For example look at https://user-images.githubusercontent.com/32298537/268449679-0509be37-c97e-4ccc-9015-b077e4ed2990.png
It displayed "Off oC".
This change in the specified property removes the oC from the UI, so the mode correctly shows "Off" without any unit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenPru BenPru BenPru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhammen @BenPru