ResideInNamespaceMatching with nested+internal types

[kl1mm]

Hi BenMorris,
we ran into a problem when trying to validate our nested internal types, which we first filtered for ResideInNamespaceMatching.

After examining the NetArchTest code, we found the extension method TypeDefinitionExtensions.GetNamespace, which only checks IsNestedPrivate or IsNestedPublic. For testing, we changed our class from internal to private and it worked.

        public static string GetNamespace(this TypeDefinition typeDefinition)
        {
            if (typeDefinition.IsNestedPrivate || typeDefinition.IsNestedPublic)
            {
                return typeDefinition.DeclaringType.FullName;
            }

            return typeDefinition.Namespace;
        }

[NeVeSpl]

I do not know what the author had in mind by restricting it only to private and public nested types, especially that in another place it is less restrictive:

NetArchTest/src/NetArchTest.Rules/Extensions/TypeReferenceExtensions.cs

Lines 23 to 30 in 23fd270

	public static string GetNamespace(this TypeReference typeReference)
	{
	if (typeReference.IsNested)
	{
	return typeReference?.DeclaringType.FullName;
	}
	return typeReference.Namespace;
	}

I guess it is my mistake, since I am the one who wrote both methods :D .