Skip to content

Managed Elements Get Moved Relative To Comments & Other Unmanaged Elements #1

@BellCubeDev

Description

@BellCubeDev
Before After
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="http://qconsulting.ca/fo3/ModConfig5.0.xsd">
    <moduleName>Banana Mod</moduleName>
    <moduleImage path="images\decorative\BANANA.jpg" />
    <requiredInstallFiles>
        <file source="" />
        <folder source="" />
    </requiredInstallFiles>
    <conditionalFileInstalls>
        <patterns>
            <pattern>
                <dependencies />
                <files>
                    <file source="" />
                    <folder source="" />
                </files>
            </pattern>
        </patterns>
    </conditionalFileInstalls>
    <!-- comment -->
</config>
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="http://qconsulting.ca/fo3/ModConfig5.0.xsd">
    <moduleName>Banana Mod</moduleName>
    <moduleImage path="images\decorative\BANANA.jpg" />
    <!-- comment -->
    <requiredInstallFiles>
        <file source="" />
        <folder source="" />
    </requiredInstallFiles>
    <conditionalFileInstalls>
        <patterns>
            <pattern>
                <dependencies />
                <files>
                    <file source="" />
                    <folder source="" />
                </files>
            </pattern>
        </patterns>
    </conditionalFileInstalls>
</config>
Diff
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="http://qconsulting.ca/fo3/ModConfig5.0.xsd">
    <moduleName>Banana Mod</moduleName>
    <moduleImage path="images\decorative\BANANA.jpg" />
+    <!-- comment -->
    <requiredInstallFiles>
        <file source="" />
        <folder source="" />
    </requiredInstallFiles>
    <conditionalFileInstalls>
        <patterns>
            <pattern>
                <dependencies />
                <files>
                    <file source="" />
                    <folder source="" />
                </files>
            </pattern>
        </patterns>
    </conditionalFileInstalls>
-    <!-- comment -->
</config>

Tasks:

  • Determine how to reorder elements when reordering is required
  • Implement this in every place where multiple elements are handled
  • Write tests to ensure this issue doesn't appear in the future

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions