Fix several highlighting issues that occur during menu navigation #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove the check if cursor is same as prev_cursor field, which prevents preview updating when returning to an existing menu window
When a submenu is closed and the parent menu regains focus, restore the context highlight if it is set (i.e. if the cursor field is set). Otherwise clear the context highlight.
In CursorMoved autocmd, the prev_cursor field is only updated through the quick_navigation function. The hover highlight update takes the prev_cursor field as an argument and so prior to this fix, the hover highlight would only be updated when the quick navigation config option was enabled
theofabilous
force-pushed
the
fix-highlight
branch
from
d2a309d
to
9980368
Compare
|
Now passing the previously failing test. The implementation that fixes preview highlighting when returning to an existing menu differs from what I had done in #49 (which I originally used for this PR), so instead of adding a commit that rolls back changes in previous commits I rebased and force pushed to keep the commit sequence clean. The behaviour is the same as before (save the bug caught by the tester). Marking this as ready for review |
Bekaboo
pushed a commit
that referenced
this pull request
Jul 8, 2023
* fix(menu): preview doesn't update on menu reopen - remove the check if cursor is same as prev_cursor field, which prevents preview updating when returning to an existing menu window * fix(menu): context highlight not restored when submenu closed When a submenu is closed and the parent menu regains focus, restore the context highlight if it is set (i.e. if the cursor field is set). Otherwise clear the context highlight. * fix(menu): hover highlight broken if quick navigation disabled In CursorMoved autocmd, the prev_cursor field is only updated through the quick_navigation function. The hover highlight update takes the prev_cursor field as an argument and so prior to this fix, the hover highlight would only be updated when the quick navigation config option was enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally part of #49
This fixes the updating of preview highlights when:
See the GIFs below for a comparison of the behavior before and after.
Before
After
This also fixes the updating of current context highlights when returning to a submenu. Prior to these changes, returning to a parent menu would retain the context highlight of the menu entry that was the parent.
Finally, the hover highlighting in menus would never update if quick navigation was disabled, which has been fixed.
Tasks
menu_spec.lua