Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mini.icons support #186

Closed
wants to merge 19 commits into from
Closed

Add mini.icons support #186

wants to merge 19 commits into from

Conversation

mathjiajia
Copy link

Still, it will be good to support mini.icons.
The default is nvim-web-devicons.

@Bekaboo
Copy link
Owner

Bekaboo commented Sep 25, 2024

Thanks for your PR! However I plan to add a more generic way to allow users to define their own icon provider, not just mini.icons or nvim-web-devicons. Ideally, the provider is a user-defined callback with parameters path and ft and returns an icon and an icon_hl.

@Bekaboo
Copy link
Owner

Bekaboo commented Oct 26, 2024 •
edited
Loading

@mathjiajia I've pushed changes in commit a1b893c to allow users to customize dir and file icons using opts.icons.kinds.file_icon and opts.icons.kinds.dir_icon. Can you try to implement mini.icons support in the default callback of these two options?

bekaboo and others added 17 commits October 26, 2024 13:02
@mathjiajia
refactor(sources-path): simplify get_icon_and_hl()
5dc12d0
@mathjiajia
refactor(hlgroups)!: don't depend on cmp hlgroups
449648a
@mathjiajia
refactor(hlgroups)!: link to ts hl instead of regex syntax hl
d16e313
@mathjiajia
feat(sources-treesitter): reduce consecutive spaces in ts symbol name
62c8c1f
@mathjiajia
fix(api): shouldn't reorient when jumping to context
714185d
@mathjiajia
refactor(sources): lsp: respect opts.general.update_events
419a2bb
@mathjiajia
perf(configs): by default don't update in insert mode
afe5d4f
@mathjiajia
refactor(utils.bar): move some bar helper funcs to utils/bar.lua
bfb8eda
@mathjiajia
refactor(configs)!: deprecate opts.general
e4d0827
@mathjiajia
docs(vimdoc): add missing entry for fzf options in toc
0f3e8d1
@mathjiajia
docs: reorder options section
fb5b89b
@mathjiajia
docs: show default value first for opts.sources.terminal.name
2a30a61
@mathjiajia
feat(configs)!: deprecate use_devicons, allow dir/file icon callback
10573da
@mathjiajia
docs(readme): fix description of opts.sources.terminal.icon
b692801
@mathjiajia
fix(sources-terminal): icon shown when opts.icons.enable is false
7df03fd
@mathjiajia
feat: support mini.icons
1c50550
@mathjiajia
modify config
0e16404
@mathjiajia
Copy link
Author

I will reopen a PR

@mathjiajia mathjiajia closed this Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathjiajia @Bekaboo