Fix script compare with negative number exception #896
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue:
#832
Analysis:
In the example of nested groups in Lexy, the matching behavior is somewhat strange. Therefore, it is recommended to temporarily avoid using nested groups.
foonathan/lexy#219
Solution:
Remove nested groups and move
string_concat
into comparison operations. This actually aligns better with intuition, since theoretically it should be possible to performcomparison
operations between twostring_concat
operations.References:
https://github.com/foonathan/lexy/blob/77ba5fa5a62f16b3ab5440c6d6ef42a7cdd176bb/tests/lexy/dsl/expression.cpp#L1193-L1196
https://lexy.foonathan.net/reference/dsl/expression/#groups