Skip to content

Fix script compare with negative number exception #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

Aglargil
Copy link
Contributor

Fix issue:

#832

Analysis:

In the example of nested groups in Lexy, the matching behavior is somewhat strange. Therefore, it is recommended to temporarily avoid using nested groups.
foonathan/lexy#219

Solution:

Remove nested groups and move string_concat into comparison operations. This actually aligns better with intuition, since theoretically it should be possible to perform comparison operations between two string_concat operations.

References:

https://github.com/foonathan/lexy/blob/77ba5fa5a62f16b3ab5440c6d6ef42a7cdd176bb/tests/lexy/dsl/expression.cpp#L1193-L1196
https://lexy.foonathan.net/reference/dsl/expression/#groups

@facontidavide facontidavide merged commit 40d535d into BehaviorTree:master Dec 13, 2024
9 checks passed
@facontidavide
Copy link
Collaborator

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants