Response headers are unavailable outside the WebApiContext

[fgm]

Since $response has been set to private and $headers is currently only used for request headers, contexts inheriting WebApiContext have no way to access the response headers.

Suggested change:

• either mark $response as protected instead of private
• or add $this->headers = $this->response->getHeaders(); at the end of sendRequest(), making headers usable for both request and response
• or provide separate properties+accessors for request and response headers.

[stof]

the second option is invalid. Request headers and response headers are 2 totally different stuff. They should not be mixed in the same property (it would break stuff when sending a second request).

[fgm]

Then 1 or 3 ? I prefer 1 as it does not decide on behalf of the users, and keeps their options open.

2 could probably work too, but that would require awkward scenarios resetting the headers before adding new ones, so I agree it is not a good idea.

[stof]

2 cannot work, because it mean you loose the configured request headers when receiving a response. and we cannot reset the array before sendign a request, as this would defeat the whole point of adding this array in the first place.

I don't like 1 because it means that the response property becomes an extension point of the context, for which we cannot do any change without BC break. This would restrict our possibilities too much for the future. Thus, each user of the response property would have to be careful when using it, because its type is Response|null

I prefer doing a bigger refactoring to include things coming from the RestExtension. See #3.
It is just that I have only a limited amount of time, and my priorities for the moment are to release MinkExtension and Symfony2Extension (which are ready for the release) as well as Mink 1.6 (the plan is the end of the weekend).

[dready]

Hi!

Could you at least make the response object available via getter...

it's not possible to add additional assertions in our contexts as our hands are tight at the moment.

i could send a pull request if you wish.

best regards, thomas

[pasxel]

either mark $response as protected instead of private
+1

[dready]

@pasxel i would not recommend that as then you cannot guarantee what someone will do with $response. Better having a getter for it. but that's just my opinion..

[pasxel]

@dready Yes, I agree. The main thing to get response in the child class.

[dantleech]

+1

[tomasz-janiczek]

+1

[dready]

actually there is a pull request waiting for this...
#10

[AndyWendt]

👍 I NEED TO GET TO THE RESPONSE

[juliobetta]

For god's sake, let us get access to response.

[kwisatz]

👍 Required since we would like to use our own, unescaped regexes, etc.

[dantleech]

ping @stof

[njbarrett]

Yeah, we need to access the response somehow.