Mobility Atomization 2: Incapacitation #9491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
your commits are name wrong |
Bro let me test it first I dun want this shit to break 😭 |
|
I didnt merge it |
Tsar-Salat
force-pushed
the
Incapacitated
branch
from
5de4725
to
f0dda96
Compare
Tsar-Salat
force-pushed
the
Incapacitated
branch
from
f0dda96
to
aefa1fb
Compare
|
amended commit message to be the correct one |
itsmeow
approved these changes
Jul 31, 2023
ss13-beebot
added a commit
that referenced
this pull request
Jul 31, 2023
PowerfulBacon
added a commit
to PowerfulBacon/BeeStation-Hornet-Bacons-Fork
that referenced
this pull request
Aug 18, 2023
commit b128b8ab090be2ca1cd20838c43b3682294055fe
Author: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>
Date: Tue Aug 8 08:00:15 2023 +0100
Standardises this nonsense
commit 2d16fe0e091c9900bd8649ba3908523eab7e0c81
Author: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>
Date: Tue Aug 8 07:55:07 2023 +0100
Update code/datums/components/buffer.dm
commit 06bc2ea5e8f1688f94ff4d17f1beed04dbad1b59
Merge: 1bb5e0b26a 0621b784f7
Author: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>
Date: Wed Aug 2 19:00:26 2023 +0200
Merge branch 'master' into reworks-multitool-buffer
commit 0621b784f7fea1ea3f2d842a9aa59c1a99ec4bff
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Wed Aug 2 00:04:55 2023 +0000
Automatic changelog compile [ci skip]
commit 25b4536855ab4f8d8d77318d7ee0a21899b3bfee
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Tue Aug 1 08:02:12 2023 +0000
Automatic changelog compile [ci skip]
commit 35b657566cb1b0df0868eafae491e929c560e75e
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Tue Aug 1 02:17:40 2023 -0500
Automatic changelog generation for PR #9530 [ci skip]
commit 71409e6ffc20a32f43e4d7c51c211a05feb6afc2
Author: Tyranicranger4 <80382633+Tyranicranger4@users.noreply.github.com>
Date: Tue Aug 1 00:08:38 2023 -0700
Adds proper logging to emagged recycler crushing (#9530)
* initial
* requested changes
commit 9473916432e645c966f5ce63bdc460fcf8890790
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Tue Aug 1 04:02:16 2023 +0000
Automatic changelog compile [ci skip]
commit f8b71f819e0f3aaf5ce2f9c6e2fd4b5f8f94af4b
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Mon Jul 31 23:00:30 2023 -0500
Automatic changelog generation for PR #9572 [ci skip]
commit ace6476d1fa2a26ff98266a80173bad4686f6dd8
Author: Lucy <lucy@absolucy.moe>
Date: Mon Jul 31 23:52:17 2023 -0400
fix admin looc blah blah blah (#9572)
commit d856eb2eff40d436e4db631afcb45ee724842e73
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Tue Aug 1 03:01:59 2023 +0000
Automatic changelog compile [ci skip]
commit 72a8cdd140ba29f3d1348b79473010a71f37cb14
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Mon Jul 31 21:31:59 2023 -0500
Automatic changelog generation for PR #9438 [ci skip]
commit c7cb9bb7ec6aefea2abcd4d3fb804156fa157246
Author: AgentCitrus <35978630+AgentCitrus@users.noreply.github.com>
Date: Mon Jul 31 22:23:06 2023 -0400
Supermatter Visual Upgrade (#9438)
* implements distortion effects
* small post-explosion remnant distortion
* particles and a new explosion effect
* fixes the countdown distortion bug
* no tile bound on the explosion
* optimizations + fixes
* code cleanup
* conditional overlay change
* yes
* Update code/modules/power/supermatter/supermatter.dm
Co-authored-by: itsmeow <itsmeow@itsmeow.dev>
* done
* does the other thing yes
* we did it hooray
* nitpick
---------
Co-authored-by: itsmeow <itsmeow@itsmeow.dev>
commit d57b86411870ed4bb5ea89371784829f9b684204
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Tue Aug 1 01:21:31 2023 +0000
Automatic changelog compile [ci skip]
commit 727c319a69513ddcc3b5096e249029a674578b1b
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Mon Jul 31 19:23:51 2023 -0500
Automatic changelog generation for PR #9085 [ci skip]
commit 2ff7197c47e7fc8a091dca002bc7fdeba3ea4469
Author: XeonMations <62395746+XeonMations@users.noreply.github.com>
Date: Tue Aug 1 03:12:38 2023 +0300
[Port] Adds sentient monkey helmets (#9085)
* Helmets
Yet to fix runtimes during removal due to qdel being referenced multiple times
* Monkey 2
Changed to seperate file, yet to fix the runtime when removing headset from own head as a monkey
* Fixed runtime issues
Fixed runtime issue when removing own helmet as a monkey, as well as adding a clause to delete the helmet itself if you somehow manage to remove a helmet during polling
* Adds a timer to the removal of the helmet
* fixes the icon so it doesn't disappear
* Small grammar change
* Prefs menu stuff and proper poll ignore
* Updated polling check code to make it look cleaner
* visible_messages, eh?
* Antispam is actually now antispam
* we're getting there...
* Should've refectored the type a while ago
* refactor that a bit...
* Well, forgot about the pack
* Spliting up disconnet
* Weakening the magnification reference
* Knock that off
* Whoopsie
* Even more split
* Maybe not do that?
* Makes a few comments more up to date
* Major Redux 2: Mind Swap Boogaloo
* realized a small flaw
* I messed up using signals this whole time...
* Two things one commit (icon change, and one misc)
* obj version now here, and mob version named right
* MAYBE I GOT IT THIS TIME
* Well that was pointless
* Hopefully this reads a bit clearer now
* Reverts accidental void cloak change
* Cooldowns: Now with 100% more define usage
* Poll now has an additional check as suggested
* Refactored polling + removed from role preferences
* Updated name + desc, removed examine proc
* Fixed singular comma in special_roles list
* Fixed runtime issue with ghostize
* Updated poll for mobs to work with meowdev changes, adds check to see if monkey is alive
* New sprite, who this?
* Changed monkey allegiance text
* "It should be simple to replicate yourself"
* Like so?
* now?
* Refactors Discoordinated Trauma Trait
* Something about monkeys on typewriters...
* more tweaks to the item itself? sign me up!
* Fixed unexisting variable code.
---------
Co-authored-by: HowToLoLu <jaxsoon.ellison@gmail.com>
commit 6b0276329719f4dd39338cb6fbf5992654879abe
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Tue Aug 1 00:09:30 2023 +0000
Automatic changelog compile [ci skip]
commit 99dc2f1ee163fa6c2457feceef472c2742a7698a
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Mon Jul 31 19:07:20 2023 -0500
Automatic changelog generation for PR #9561 [ci skip]
commit 0c4e563241d301fbe1162f326eab37d03e53e9f8
Author: Rukofamicom <oozelingcomplaints@gmail.com>
Date: Mon Jul 31 18:58:07 2023 -0500
Fixes grilles (#9561)
commit 6111d8f6edd6640b693027942f3277f90c221c38
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Mon Jul 31 23:02:10 2023 +0000
Automatic changelog compile [ci skip]
commit 028ef335a24f93fbe15d845c3c4a98eea073feb8
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Mon Jul 31 17:34:10 2023 -0500
Automatic changelog generation for PR #9495 [ci skip]
commit 62f575a3149f60fc353b247940fd0b4233210dce
Author: Lamiales <110184118+CydiaLamiales@users.noreply.github.com>
Date: Tue Aug 1 01:26:00 2023 +0300
fixy (#9495)
commit ff6728be27edecca3ce45dd784caca05cca8726c
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Mon Jul 31 17:25:01 2023 -0500
Automatic changelog generation for PR #9536 [ci skip]
commit e6acada19259fa7f9048914fef31cd74722070a4
Author: itsmeow <itsmeow@itsmeow.dev>
Date: Mon Jul 31 18:09:23 2023 -0400
Load circuit components from USB ports on demand, saving 0.5s of init time (0.7s on prod) (#69664) (#9536)
We create 2,383 circuit components (on whatever map I was looking at on Sybil at the time, don't know) from USB ports every round, quite pricey. This makes them initialize once when a USB is first plugged in.
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
commit 71dd1251329f4bd28645f1fb7ffad0eb99233f6c
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Mon Jul 31 17:16:16 2023 -0500
Automatic changelog generation for PR #9504 [ci skip]
commit 85d829b8e6d58058a16fe5c4c6c7e68a599764b3
Author: Tsar-Salat <62388554+Tsar-Salat@users.noreply.github.com>
Date: Mon Jul 31 18:05:09 2023 -0400
https://github.com/tgstation/tgstation/pull/45371 (#9504)
commit c817b09b84a219fb498b24eb676617fe535adbe8
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Mon Jul 31 22:01:54 2023 +0000
Automatic changelog compile [ci skip]
commit ecf62f3031426913424f1f86d60f4e167bd4bf84
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Mon Jul 31 16:47:25 2023 -0500
Automatic changelog generation for PR #9512 [ci skip]
commit 68ae97245c59157852c0e00c6315770a6555237d
Author: BriggsIDP <107176252+BriggsIDP@users.noreply.github.com>
Date: Mon Jul 31 22:38:57 2023 +0100
Reduced plant HP, remove tree shadows (#9512)
* reduced plant HP, removed shadow
* Update beestation.dme
* Update beestation.dme
commit bcf783f2854294f2d85915f2ff721fca29af9189
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Mon Jul 31 16:15:47 2023 -0500
Automatic changelog generation for PR #9515 [ci skip]
commit f6212d506b2bfb9a1ead00baa5d930bbbfd7d43c
Author: Lamiales <110184118+CydiaLamiales@users.noreply.github.com>
Date: Mon Jul 31 23:56:48 2023 +0300
SM's anomalies spawn way less harvested pierced realities (#9515)
* first-thing
* no-spammerino
* no_it_should_be_like_this
commit 9ced3a737bcb543176f3ae182f5771599f029758
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Mon Jul 31 21:02:01 2023 +0000
Automatic changelog compile [ci skip]
commit 796870c80da625f74c21d9c5f8888cf3a23d9670
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Mon Jul 31 15:46:48 2023 -0500
Automatic changelog generation for PR #9544 [ci skip]
commit eeb171547a8b1289f6def07923e41d3d40bd2af9
Author: Lamiales <110184118+CydiaLamiales@users.noreply.github.com>
Date: Mon Jul 31 23:25:15 2023 +0300
one-line-change (#9544)
commit dd6be03dc079eb100af996b9b255c84154de78e2
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Mon Jul 31 15:36:39 2023 -0500
Automatic changelog generation for PR #9218 [ci skip]
commit 62649a5aff9e622fba2127067215d0a86cbb42b7
Author: mystery3525 <30960302+mystery3525@users.noreply.github.com>
Date: Mon Jul 31 16:23:08 2023 -0400
Rad station power cable improvements & more (#9218)
* fixes before I sleep
* move that one apc
* gives toxin testing a light
* moves that one damn air alarm
* i forgot to move the door back
* doubles down on wire T-interesections, removes evidence locker area, re-wires AI sat, removes Bridge Hallway Area
* gives a cable coil
* hop office wire
* this area in maint was really bothering me
* removes the random high-traction tile goof
* some wires I missed
* remove lattice shit
* Gives the bomb sender a tiny fan
* god damn it floria
* fixes radstation
* empty commit
* dodgeball 4 out of 5
* address changes
* forgot an apc in maint
commit 0f7800f1a787d16ca6e636baac7e38abe783279e
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Mon Jul 31 15:25:59 2023 -0500
Automatic changelog generation for PR #9459 [ci skip]
commit d0d311181b04bf871aa6547719870a1c5b0c6713
Author: Tsar-Salat <62388554+Tsar-Salat@users.noreply.github.com>
Date: Mon Jul 31 16:00:36 2023 -0400
Kills obj/item/projectile in favour of obj/projectile (#9459)
* https://github.com/tgstation/tgstation/pull/46692
* base_icon!!!
* two update_icons?!?!
commit 3a35dee7ba8bed68a2fb71d4f911dc68cb0263d0
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Mon Jul 31 15:15:27 2023 -0500
Automatic changelog generation for PR #9407 [ci skip]
commit 1d8dd7cb1270bc38f30301bdd0d7775e57c1f109
Author: Lucy <lucy@absolucy.moe>
Date: Mon Jul 31 16:00:05 2023 -0400
Patch up the jankiness of LOOC (#9407)
* Patched up the jank of LOOC
* Handle reviews.
commit 811a4d4632439a274e2aa27366e584dc8b0d7483
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Mon Jul 31 20:01:53 2023 +0000
Automatic changelog compile [ci skip]
commit 7c6dcde31dfd9e309584ee5d97fecbe1e2c3996a
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Mon Jul 31 14:52:19 2023 -0500
Automatic changelog generation for PR #9502 [ci skip]
commit 19cac061f68567dc07ed09221eeb71c8e0b332b5
Author: JixS4v <61665800+JixS4v@users.noreply.github.com>
Date: Mon Jul 31 21:41:58 2023 +0200
[PORT] BCI component fixes and additions (#9502)
* server config
* Revert "server config"
This reverts commit f7c59fc6216d94d01801cbd1735ba1bf5d6d609a.
* New BCI components!
* forgot to update beestation.dme
* fixes a couple of oversights when porting
* removes the vox component because I dumb and lazy
* Small oopsie
commit 5c6e2e08028af0b8b5523d4c59bef600f2af60be
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Mon Jul 31 14:42:00 2023 -0500
Automatic changelog generation for PR #9469 [ci skip]
commit d433857dcbc4838121fc0fd475480017f117ea20
Author: itsmeow <itsmeow@itsmeow.dev>
Date: Mon Jul 31 15:30:46 2023 -0400
Maploader Update/Optimizations and Atoms Init fix (#9469)
* Macro optimizes SSmapping saving 50% (#69632)
* 'optimizes' space transitions by like 0.06 seconds, makes them easier to read tho, so that's an upside
* ''''optimizes'''' parsed map loading
I'm honestly not sure how big a difference this makes, looked like small
percentage points if anything
It's a bit more internally concistent at least, which is nice. Also I
understand the system now.
I'd like to think it helped but I think this is kinda a "do you think
it's easier to read" sort of situation. if it did help it was by the
skin of its teeth
* Saves 0.6 seconds off loading meta and lavaland's map files
This is just a lot of micro stuff.
1: Bound checks don't need to be inside for loops, we can instead bound the iteration counts
2: TGM and DMM are parsed differently. in dmm a grid_set is one z level,
in tgm it's one collumn. Realizing this allows you to skip copytexts and
other such silly in the tgm implemenentation, saving a good bit of time
3: Min/max bounds do not need to be checked inside for loops, and can
instead be handled outside of them, because we know the order of x
and y iteration. This saves 0.2 seconds
I may or may not have made the code harder to read, if so let me know
and I'll check it over.
* Micro ops key caching significantly. Fixes macros bug
inserting \ into a dmm with no valid target would just less then loop
the string. Dumb
Anyway, optimizations. I save a LOT of time by not needing to call
find_next_delimiter_position for every entry and var set. (like maybe 0.5
seconds, not totally sure)
I save this by using splittext, which is significantly faster. this
would cause parsing issues if you could embed \n into dmms, but you
can't, so I'm safe.
Lemme see uh, lots of little things, stuff that's suboptimal or could be
done cheaper. Some "hey you and I both know a \" is 2 chars long sort of
stuff
I removed trim_text because the quote trimming was never actually used,
and the space trimming was slower then using the code in trim. I also
micro'd trim to save a bit of time. this saves another maybe 0.5.
Few other things, I think that's the main of it. Gives me the fuzzy
feelings
* Saves 50% of build_coordinate's time
Micro optimizing go brrrrr
I made turf_blacklist an assoc list rather then just a normal one, so
lookups are O(log n) instead of O(n). Also it's faster for the base case
of loading mostly space.
Instead of toggling the map loader right before and right after New()
calls, we toggle at the start of mapload, and disable then reenable if
we check tick. This saves like 0.3 seconds
Rather then tracking an area cache ourselves, and needing to pass it
around, we use a locally static list to reference the global list of
area -> type. This is much faster, if slightly fragile.
Rather then checking for a null turf at every line, we do it at the
start of the proc and not after. Faster this way, tho it can in theory
drop area vvs.
Avoids calling world.preloader_setup unless we actually have a unique
set of attributes. We use another static list to make this comparison
cheap. This saves another 0.3
Rather then checking for area paths in the turf logic, or vis versa, we
assume we are creating the type implied by the index we're reading off.
So only the last type entry will be loaded like a turf, etc.
This is slightly unsafe but saves a good bit of time, and will properly
error on fucked maps.
Also, rather then using a datum to hold preloader vars, we use 2 global
variables. This is faster.
This marks the end of my optimizations for direct maploading. I've
reduced the cost of loading a map by more then 50% now. Get owned.
* Adds a define for maploading tick check
* makes shuttles load again, removes some of the hard limits I had on the reader for profiling
* Macro ops cave generation
Cave generation was insanely more expensive then it had any right to be.
Maybe 0.5 seconds was saved off not doing a range(12) for EVERY SPAWNED
MOB.
0.14 was saved off using expanded weighted lists (A new idea of mine)
This is useful because I can take a weighted list, and condense it into
weight * path count. This is more memory heavy, and costs more to
create, but is so much faster then the proc.
I also added a naive implementation of gcd to make this a bit less bad.
It's not great, but it'll do for this usecase.
Oh and I changed some ChangeTurfs into New()s. I'm still not entirely
sure what the core difference between the two is, but it seems to work
fine.
I believe it's safe because the turf below us hasn't init'd yet, there's
nothing to take from them. It's like 3 seconds faster too so I'll be sad
when it turns out I'm being dumb
* Micros river spawning
This uses the same sort of concepts as the last change, mostly New being
preferable to ChangeTurf at this level of code.
This bit isn't nearly as detailed as the last few, I honestly got a bit
tired. It's still like 0.4 seconds saved tho
* Micros ruin loading
Turns out it saves time if you don't check area type for every tile on a
ruin. Not a whole ton faster, like 0.03, but faster.
Saves even more time (0.1) to not iterate all your ruin's turfs 3 times
to clear away lavaland mobs, when you're IN SPACE who wrote this.
Oh it also saves time to only pull your turf list once, rather then 3
times
* Makes the ChangeTurf same turf optimization work properly again, and converts baseturfs into a string_list (#54277)
I've converted baseturfs into a string list, I had to add a helper proc for baseturf stringlistifying, as the system expects single length baseturfs to not be a list, and I needed to support that. I added a length check of 100 to the helper proc, to help prevent more stuff like what got us into this mess in the first place, the kilo oom bug.
Makes ChangeTurf a lot faster in some cases, as it should be, and saves a lot of memory with cached lists.
* Cleans up a mistake with baseturfs, prevents ref oddness (#54888)
When there's only one baseturf, we expect it to be stored not as a list, but as a single item.
I failed to support this in my string lists pr, which caused a few related issues.
Fixes #54880 , alt of #54883
* Breaking baseturf limits now directly spawns an error turf (#62414)
Makes breaking the baseturf length limit spawn a baseturf warning tile as a replacement for the current tile.
Doesn't appear to cause infinite loops!
* Ensures areas are allowed to be non unique (#70118)
Did you know that areas can be non unique (unique per area)
I didn't, and I wrote mapping code such that we'd make all areas unique
This fixes that. It costs 0.1 seconds but without it areas don't work
anymore
* Fix area cache
* Fix clear_below and ruin marking
* Optimizes maploading again, saving 0.4 seconds on a bare init. Supports loading dmm again (#71074)
When I optimized maploading in (#69632
d34fa4c642839215df5ba985d098a04e4d555b5b) I made some assumptions based
on the TGM format, so how newlines worked and such.
This would break attempts to load maps in the dmm format, so maps edited
in dreammaker and not commited yet.
I've fixed this by adding a map format detection system This has allowed
me to further optimize tgm by taking advantage of a list of assumptions.
I printed them out in a comment near the top of the file.
This showed the most in build_cache, which went from 0.7 seconds to 0.4
on my machine.
The optimizations here involve using regex to pull out var edits,
parsing models line by line rather then all at once, which allows for
much cheaper parsing, and avoiding a safety trim()
I did also save like 0.05 seconds in load, because I could pull a bunch
of operations out to once per map, because of prior knowledge of where
the max/min x and y's would be.
Speed. Also ensures mappers don't get fucked over.
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
* Undo mob spawning optimization because it breaks things
* Maybe fix heretic test?
* Fix mob generation ignoring NO_RUINS
* Fix lint
* Optimize mob gen by reducing range and altering weights
* Remove commented code
* Less tendrils please
* Just enforce an overall 6-tile distance to reduce the spawners spam
* Slightly reduce overall spawn chance to account for worse spacing and make it easier on miners
* Fix overall mob spawn counts by halfing the chance again and normalize the weights (they were being overriden in LavalandGenerator anyway)
* Use range() instead of urange()
* Fully fixes atom init desyncs (#76179)
The old system was... ok, but the stack trace was unfortuante, and the
potential to double remove was silly.
Let's use a list of source, value instead, to block overremovals and
properly support different load states
Prevents a bug a goodhearted bagilmin showed me where shuttles would
randomly just fail to load.
Calling clear twice should not be a failure
:cl:
fix: Maps loaded post init will no longer randomly enter a failed state.
Hopefully.
/:cl:
* Fixes a runtime in atom init management (#76241)
The issue was map verification calling build_cache, which uses the
define which enables/disables init values on sleep. We avoid this by
using a var on map datums and using that to enable the init value
modification only when we are actually loading stuff.
Also fixes a bug in clear_tracked_initialize() where it being called
with no values lead to bad values/potentially overriding initialized on
accident.
Also also I forgot how for loops worked so this would not have worked
regardless
Code should like, function
* Use a list of mobs spawned rather than range(6) - similar performance but probably slightly better
* Don't need this var
* Convert back to old spawning for the same performance, no more spacing issues!
* fix #54855 (#54857)
Fix disappearing baseturfs
Bugs is bad
(Lemon: Dumb mistake with length of one baseturfs, this fixes it and prevents random space tiles spawning with proper crowbar use)
* Webedit about an old baseturfs line that was not removed. (#54860)
A line that modifies baseturfs was left in with its replacement, this cleans it up
* Shuttle baseturf caching
* Skipover caching
* Fix arrivals shuttle
* Builds logic that manages turfs contained inside an area (#70966)
Area contents isn't a real list, instead it involves filtering
everything in world
This is slow, and something we should have better support for.
So instead, lets manage a list of turfs inside our area. This is simple,
since we already move turfs by area contents anyway
This should speed up the uses I've found, and opens us up to using this
pattern more often, which should make dev work easier.
By nature this is a tad fragile, so I've added a unit test to double
check my work
Rather then instantly removing turfs from the contained_turfs list, we
enter them into a list of turfs to pull out, later.
Then we just use a getter for contained_turfs rather then a var read
This means we don't need to generate a lot of usage off removing turf by
turf from space, and can instead do it only when we need to
I've added a subsystem to manage this process as well, to ensure we
don't get any out of memory errors. It goes entry by entry, ensuring we
get no overtime.
This allows me to keep things like space clean, while keeping high
amounts of usage on a sepearate subsystem when convienient
As a part of this goal of keeping space's churn as low as possible, I've
setup code to ensure we do not add turfs to areas during a z level
increment adjacent mapload. this saves a LOT of time, but is a tad
messy
I've expanded where we use contained_turfs, including into some cases
that filter for objects in areas. need to see if this is sane or not.
Builds sortedAreas on demand, caching until we mark the cache as
violated
It's faster, and it also has the same behavior
I'm not posting speed changes cause frankly they're gonna be a bit
scattered and I'm scared to.
@Mothblocks if you'd like I can look into it. I think it'll pay for
itself just off `reg_in_areas_in_z` (I looked into it. it's really hard
to tell, sometimes it's a bit slower (0.7), sometimes it's 2 seconds
(0.5 if you use the old master figure) faster. life is pain.)
Less stupid, more flexible, more speed
Co-authored-by: san7890 <the@san7890.com>
* Move build_area_turfs to correct spot
* Fix kilo arrivals parsing error
* Fix the debug message
* Fix the holodeck
---------
Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Co-authored-by: Dennok <Deneles@yandex.ru>
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
Co-authored-by: san7890 <the@san7890.com>
commit f2de7a09b5740c41f4f0034464a008dfdc6f740d
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Mon Jul 31 14:25:55 2023 -0500
Automatic changelog generation for PR #9491 [ci skip]
commit 69c2e7f56e8238d17164f749538c8b0e1241dbc1
Author: Tsar-Salat <62388554+Tsar-Salat@users.noreply.github.com>
Date: Mon Jul 31 15:19:51 2023 -0400
Mobility Atomization 2: Incapacitation (#9491)
* https://github.com/tgstation/tgstation/pull/50321
* https://github.com/tgstation/tgstation/pull/50327
* cleanup
* add trait to the globalvars
commit ad25a6c1f2f633d15381710f5c259cfb987c1db6
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Mon Jul 31 19:02:05 2023 +0000
Automatic changelog compile [ci skip]
commit db89d01f7067cc6391f98958475f6c4d17f9fb08
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Mon Jul 31 13:39:20 2023 -0500
Automatic changelog generation for PR #9519 [ci skip]
commit c601c8f92350d03b4e15afe1131dc760999dbb6a
Author: XeonMations <62395746+XeonMations@users.noreply.github.com>
Date: Mon Jul 31 21:25:49 2023 +0300
Fixes a few radstation issues (#9519)
* Fixed issues.
Fixed atmospherics mixer having wrong settings.
Fixed air alarm placed wrongly in exploration preparation room.
Fixed air in telecommunications control room.
* Removed usage of step x + y variables
* Figured out how you're actually supposed to do air alarms
should fix the run_linter errors
commit 4a67b69157ec6279cffe8e170c2a0d520dd40854
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Mon Jul 31 17:02:19 2023 +0000
Automatic changelog compile [ci skip]
commit dd2231f740d9720f76742cc9c0e6c750e4ab98c3
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Mon Jul 31 11:32:51 2023 -0500
Automatic changelog generation for PR #9555 [ci skip]
commit 28d6335be60ca190084987e5594792c8f99b684d
Author: itsmeow <itsmeow@itsmeow.dev>
Date: Mon Jul 31 12:24:57 2023 -0400
Random Turf init optimizations (#9555)
* open ChangeTurf init optimization
* Transit init optimization
commit a74b33dea7259a985745d597d3a88268bf07a090
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Mon Jul 31 07:01:53 2023 +0000
Automatic changelog compile [ci skip]
commit 569ed4a5c81fba381e777219e60da266a7193bc9
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Mon Jul 31 01:15:20 2023 -0500
Automatic changelog generation for PR #9528 [ci skip]
commit 90ba64c9be087d22f6a1fe1d49b9780f6a2a6921
Author: JixS4v <61665800+JixS4v@users.noreply.github.com>
Date: Mon Jul 31 08:06:50 2023 +0200
Honker mech equipment menu addition (#9528)
* server config
* Revert "server config"
This reverts commit f7c59fc6216d94d01801cbd1735ba1bf5d6d609a.
* Adds an equipment menu to the honker mech
commit 70ae604d9206056a256a058ab2692b55c674430b
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Mon Jul 31 01:07:40 2023 -0500
Automatic changelog generation for PR #9543 [ci skip]
commit a18e99b87444d1b3ad745201559b6c3b7a30f680
Author: ike709 <ike709@users.noreply.github.com>
Date: Sun Jul 30 23:01:24 2023 -0700
Fix invalid expression in guncode (#9543)
Credit to OpenDream / wixoa
commit f2a6634599ace3f3871d6a2dfe285e81bb0b01aa
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Mon Jul 31 01:28:14 2023 +0000
Automatic changelog compile [ci skip]
commit 20a8883ebaf684fbc15ac18ef02945d00b756648
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Sun Jul 30 19:17:08 2023 -0500
Automatic changelog generation for PR #9551 [ci skip]
commit dcbae4d6a90acf69a8f292b4d6da78fbd4a93ce3
Author: HowToLoLu <jaxsoon.ellison@gmail.com>
Date: Sun Jul 30 19:08:57 2023 -0500
now deleting 100% more action (#9551)
commit c2ae0301892a38f0a034ad4c355a2fd0275462c6
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Mon Jul 31 00:05:03 2023 +0000
Automatic changelog compile [ci skip]
commit 9e1e812c355ed83e28e88735ea83bbd10b632591
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Sun Jul 30 21:01:53 2023 +0000
Automatic changelog compile [ci skip]
commit d316554bdd2dbdacfbee42d16aa2536e622c2dfc
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Sun Jul 30 15:04:37 2023 -0500
Automatic changelog generation for PR #9554 [ci skip]
commit 366c2357162d00e6c386e5778be54c3dc77dfced
Author: Rukofamicom <oozelingcomplaints@gmail.com>
Date: Sun Jul 30 14:56:37 2023 -0500
Double bugfix - Package Wrap and Bluespace capsules (#9554)
* Adjusts bluespace capsule logic
Now only accepts obj/item.
* Package wrap no longer works on WEIGHT_CLASS_GIGANTIC
commit 55880935ee7f7b1ba8f1641a72a69557cb4c8628
Author: Lamiales <110184118+CydiaLamiales@users.noreply.github.com>
Date: Sun Jul 30 22:52:09 2023 +0300
Buffs the Poisoned Knife (#9398)
* buffe
* Update code/modules/uplink/uplink_items.dm
Co-authored-by: Rukofamicom <oozelingcomplaints@gmail.com>
* changes
---------
Co-authored-by: Rukofamicom <oozelingcomplaints@gmail.com>
commit 28c9a049617f5b1f403163a0ed621acb4266ef01
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Sun Jul 30 14:58:34 2023 -0500
Automatic changelog generation for PR #9422 [ci skip]
commit f5eedc9aaf7bbcea7234035c5cb2ed3ac9df2d16
Author: Lucy <lucy@absolucy.moe>
Date: Sun Jul 30 15:52:04 2023 -0400
Sound synthesizer now has a proper cooldown (#9422)
* Sound synthesizer now has a proper cooldown and respects preferences
* Fix typo in comment.
* I don't see why preferences is so controversial, but whatever, I don't like arguing.
* ergvijkngthjbnrtgehjbnrtjn
commit df2d375d0ac9f49d5908019016e5177d695d63b5
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Sun Jul 30 19:01:50 2023 +0000
Automatic changelog compile [ci skip]
commit 90ab7f1ad7ed22eea9b244aacd41c56dda765a8b
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Sun Jul 30 13:37:12 2023 -0500
Automatic changelog generation for PR #9235 [ci skip]
commit 972cd29f244ff3eee024a5715e4860f7e4333a6b
Author: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>
Date: Sun Jul 30 20:31:06 2023 +0200
Removes help intent disabling blocking (#9235)
* Removes help intent disabling blocking
* Vending
* Revert "Vending"
This reverts commit 2ea9206958b88c3f4ef6d55ef4035b9580487b23.
commit 7f3c1dd64f2a60c4a948ff65c21718d710107b2e
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Sun Jul 30 16:02:01 2023 +0000
Automatic changelog compile [ci skip]
commit b5c154c0ead97b80522290d607d9c9f9c6abd4b6
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Sun Jul 30 10:13:21 2023 -0500
Automatic changelog generation for PR #9155 [ci skip]
commit eea75e742e98e394cba75ac7133e1e362f150b10
Author: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>
Date: Sun Jul 30 16:46:38 2023 +0200
Syndicate teleporter rework (#9155)
* Syndicate Teleporter Rework
Reworks the syndicate teleporter.
* Updates the description of the device
* Grammar corrects
* Uses proper do_teleport
* Makes it so bluespace anchors check destination and source
commit 8ad1bcdbfd3ecabac8632e1bf70875071a8cab65
Author: itsmeow <itsmeow@itsmeow.dev>
Date: Sun Jul 30 10:37:36 2023 -0400
Fix the order of byond tracy and auxmos (#9557)
commit 15e4a120593d6ce55417a0b9f7088e7b7d4a634b
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Sun Jul 30 15:01:55 2023 +0000
Automatic changelog compile [ci skip]
commit 14347805771ea445bc23a8d96e72fb989fe00379
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Sun Jul 30 09:18:06 2023 -0500
Automatic changelog generation for PR #8118 [ci skip]
commit 619d8b4527b3c8b6f86060680b1bdc8447611763
Author: EvilDragonfiend <87972842+EvilDragonfiend@users.noreply.github.com>
Date: Sun Jul 30 23:03:04 2023 +0900
No longer shows & in station name and silicon laws! (#8118)
* better strings
* last change
* reviewed
* better ticketing
* different approach
* Remove admin mentor sanit
* stub
---------
Co-authored-by: EvilDragonfiend <targaly@gmail.com>
commit 428cdf1f33cf6e718c85e5015840f450bae069df
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Sun Jul 30 09:11:58 2023 -0500
Automatic changelog generation for PR #9548 [ci skip]
commit 912b54979a13be5edbc92eb4e6b71c77dd441dc0
Author: itsmeow <itsmeow@itsmeow.dev>
Date: Sun Jul 30 09:56:58 2023 -0400
Add emissives to lightswitches (#9548)
* Add emissives to lightswitches and add a screwdrivered examine hint
* Fix complete darkness
commit f7f1811df0bc171f2b09deecabd376b78f2dc0d6
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Sun Jul 30 14:01:40 2023 +0000
Automatic changelog compile [ci skip]
commit ef088acd5659cec4b2ab49c4531ce651814362b4
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Sun Jul 30 09:00:47 2023 -0500
Automatic changelog generation for PR #9546 [ci skip]
commit e2699ed66515dcfe76e0e1866970a8e7cb580122
Author: Lucy <lucy@absolucy.moe>
Date: Sun Jul 30 09:54:50 2023 -0400
Roundstart lighting fixes + tweaks (#9546)
* Roundstart lighting tweaks
* Some fixups...
* Consolidate brig access into GLOB.command_areas
* Rename global lists to clarify their usage; actually add security areas
* Fix using the wrong variable...
* Small refactor to ensure HoP doesn't light up the entirety of cargo
* Science should not light up medbay.
* More refined area selections!
* Fix copy-paste error
* More tweaks
* Use bitflags instead of job titles
* Brig phys has the security bitflag, so that's no longer needed I guess...
* Light up all of genetics for the CMO.
commit 6489efc15aabba905c38e53a138e726c3a5467c9
Author: Lucy <lucy@absolucy.moe>
Date: Sun Jul 30 09:46:04 2023 -0400
Cryoed antags now display as so on the roundend report (#9533)
* Cryoed antags now display as so on roundend
* Update code/__HELPERS/roundend.dm
Co-authored-by: Rukofamicom <oozelingcomplaints@gmail.com>
---------
Co-authored-by: Rukofamicom <oozelingcomplaints@gmail.com>
commit 134f98277e3167cc18c1b5eb862bff67430b2413
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Sun Jul 30 05:02:08 2023 +0000
Automatic changelog compile [ci skip]
commit 74cc403370ef3e3956e0fa5d5bda722f93180d72
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Sat Jul 29 23:27:12 2023 -0500
Automatic changelog generation for PR #9556 [ci skip]
commit 858b69dd2350351a3cd7047df80524f09b59d126
Author: EvilDragonfiend <87972842+EvilDragonfiend@users.noreply.github.com>
Date: Sun Jul 30 13:19:44 2023 +0900
frame issue (#9556)
commit 7fd9116cef6d93622dac251e33ed5415a3b5942e
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Sun Jul 30 00:05:16 2023 +0000
Automatic changelog compile [ci skip]
commit 654f2cb157571858636d0e38b5ff42f0b74ce2ed
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Sat Jul 29 18:36:30 2023 -0500
Automatic changelog generation for PR #9547 [ci skip]
commit 638f1e6bef166730e646eb4de8cdf564d5dd39a4
Author: LemonLimeSoda <35978630+LemonLimeSoda@users.noreply.github.com>
Date: Sat Jul 29 19:30:34 2023 -0400
fixes the thing (#9547)
commit 36b3d369d8db809dc3adb2aa27ee8f9330068484
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Sat Jul 29 16:02:06 2023 +0000
Automatic changelog compile [ci skip]
commit 68511f0333d7df7f132f3d09f5bbc0025776244f
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Sat Jul 29 10:16:17 2023 -0500
Automatic changelog generation for PR #9538 [ci skip]
commit 9c1a0e3711729ef68ded7450866bc6db6152483b
Author: itsmeow <itsmeow@itsmeow.dev>
Date: Sat Jul 29 11:09:38 2023 -0400
Optimize atmos init and multiz (#9538)
* Optimize atmos init and multiz
* Change arg names back
* Remove cablerelay icons
* Update code/modules/atmospherics/environmental/LINDA_system.dm
Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>
---------
Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>
commit 50ef07105223af4fce6a982c7501e2bc080b7146
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Sat Jul 29 09:01:47 2023 +0000
Automatic changelog compile [ci skip]
commit 38e835f49f2d371919865b3c75ceb3f592b645f0
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Sat Jul 29 03:52:08 2023 -0500
Automatic changelog generation for PR #9539 [ci skip]
commit 55652d8c3af0f6ea179570c05906932217435e5f
Author: itsmeow <itsmeow@itsmeow.dev>
Date: Sat Jul 29 04:38:04 2023 -0400
Removes some unnecessary shitcode (#48910) (#9539)
Co-authored-by: MrPerson <spamtaffic@gmail.com>
commit 409fda6f42787eb364c699d8225ff62e1133868f
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Sat Jul 29 02:12:57 2023 +0000
Automatic changelog compile [ci skip]
commit 6cdf6de4afc67ab2ca8f4aaec3603b62f57fa78a
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Fri Jul 28 21:02:40 2023 -0500
Automatic changelog generation for PR #9436 [ci skip]
commit 2f53139417f7e6cc6b7418c44a0c6f55b77a7e52
Author: Tsar-Salat <62388554+Tsar-Salat@users.noreply.github.com>
Date: Fri Jul 28 21:56:43 2023 -0400
Revert "Revert "Blindness refactor and cleanup + monochrome sight"" + fixes (#9436)
* Revert "Revert "Blindness refactor and cleanup + monochrome sight (#9354)" (#9435)"
This reverts commit 76909236342f8c6d3359c6db2dc2b88deae50669.
* blurriness fix
* ai eyes
commit ae3f892a810a1938d03975711f549f61283f5d3c
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Sat Jul 29 00:04:23 2023 +0000
Automatic changelog compile [ci skip]
commit d2508827140434a6b9adee1b246c9ce90b45db13
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Fri Jul 28 18:01:55 2023 +0000
Automatic changelog compile [ci skip]
commit 0cb28cf6f5d3e15fa3001d8a2e090a9d0e449a43
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Fri Jul 28 12:15:02 2023 -0500
Automatic changelog generation for PR #9537 [ci skip]
commit b2e073f2316277605bf159ff58fbaf073b3622d9
Author: Tsar-Salat <62388554+Tsar-Salat@users.noreply.github.com>
Date: Fri Jul 28 13:08:27 2023 -0400
fixers (#9537)
commit fbc8aa5388d48670d9fd91165948aa390ef4e482
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Fri Jul 28 12:02:59 2023 -0500
Automatic changelog generation for PR #9061 [ci skip]
commit 16ded86db6ef4cfd1baba8192dd17d69cd6db058
Author: BriggsIDP <107176252+BriggsIDP@users.noreply.github.com>
Date: Fri Jul 28 17:56:45 2023 +0100
Meta & Delta Medbay rework (#9061)
* merge conflict
* double lattice
* stasis + flowers + area
* debug fixs
* more maints
* Merge conflict
* Revert "Merge conflict"
This reverts commit 040c3e81a05a51c0a04fbae126504839cda192e2.
* testing and fixes - Ready
* Fix whoopsies.
* pigeon feedback
* updates stasis code
* pigeon feedback
* feedback
* missing light switch
---------
Co-authored-by: Lucy <lucy@absolucy.moe>
commit e399d1318cf05672346c12cfb92cce26315d6675
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Fri Jul 28 08:02:02 2023 +0000
Automatic changelog compile [ci skip]
commit 2bed141e2988c3b0b61d11d06945d9311ac0e7d4
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Fri Jul 28 02:32:30 2023 -0500
Automatic changelog generation for PR #9534 [ci skip]
commit 7c910e0569e82330cec66c7917c3edd0aa2a2acd
Author: itsmeow <itsmeow@itsmeow.dev>
Date: Fri Jul 28 03:18:25 2023 -0400
Add tracy support and early world init hook (#9534)
* Add tracy support and early world init hook
* Add the linux version too, for whatever weirdo uses linux
commit d748d2ac743bb405b9e1a83e4bc0fc94b6dbc1e7
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Fri Jul 28 02:26:02 2023 -0500
Automatic changelog generation for PR #9525 [ci skip]
commit daf0f4c7aa3900990a18039a075bc45da6d5478d
Author: itsmeow <itsmeow@itsmeow.dev>
Date: Fri Jul 28 03:14:01 2023 -0400
Micro-optimize icon smoothing subsystem (#9525)
* Micro-optimize icon smoothing subsystem, cutting down more than 50% of its init time (about .8s drop on local, more on prod) (#69741)
With atoms now being 50% of the init time instead of ~80%, I've decided to poke around other subsystems.
Unfortunately they're not straight forward at all and extremely boring. bitmask_smooth() in particular is just a big proc that is called ~60k times, so I made some adjustments to its macro to reduce ops.
I removed code that looped over two entire Z-levels to find things to smooth, added by e2dd404, at a time before the initialize system. This doesn't have huge gains since it just defers to the queue anyway, but it still shaved off 0.1-0.2s on local.
I removed update_appearance(~UPDATE_SMOOTHING) from something since the person who added it doesn't remember why and it doesn't appear to do anything. Lemon thinks it's something to do with emissives, but I tested with neon carpet and it seemed to work fine.
* Nevermind, it doesn't like that
---------
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
commit 4575dca96f3c1596bbd0ee0d5de6d982c4c143c2
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Fri Jul 28 07:02:08 2023 +0000
Automatic changelog compile [ci skip]
commit 233cac1f2969a747aa7495d5386d469e4821f181
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Fri Jul 28 01:38:47 2023 -0500
Automatic changelog generation for PR #9522 [ci skip]
commit 15405a5bfa6059c8c09547bf54ad4f56b9b40b45
Author: itsmeow <itsmeow@itsmeow.dev>
Date: Fri Jul 28 02:26:50 2023 -0400
Micro-optimize turf and atom init (#9522)
* Micro-optimize turf and atom init
* Remove turf 'optimization' because it's slow
commit 614c332ffc560d87215ff9b8e395531ce2efa02f
Author: itsmeow <itsmeow@itsmeow.dev>
Date: Fri Jul 28 02:25:21 2023 -0400
Atom and turf initialize, level_trait cache optimizations, fix smoothing sorts (1.1s init) (#9523)
* Atom and turf initialize, level_trait cache
* Reorder and fix smooth groups
* Sorty sort sort
commit 07ceb0560c415ee8f9fe7e7ecc77eabf1bd3eaa3
Author: itsmeow <itsmeow@itsmeow.dev>
Date: Fri Jul 28 02:23:33 2023 -0400
Limit icon_states checks in spritesheet creation to UNIT_TESTS (saves 3s init time) (#9521)
* Limit icon_states checks in spritesheet creation to UNIT_TESTS (saves 1.6s of init time) (#69635)
* Limit icon_states check in vending/research spritesheet creation to UNIT_TESTS
* Appease the unit test gods
---------
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
commit f698c7ed29b6ea6c42c9ed7a049a066331d52165
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Fri Jul 28 01:32:01 2023 -0500
Automatic changelog generation for PR #9524 [ci skip]
commit dc8857b0d13990cb89f7b3e86c9cd6b128295939
Author: itsmeow <itsmeow@itsmeow.dev>
Date: Fri Jul 28 02:21:19 2023 -0400
Micro-optimize RegisterSignal, saving 0.3s of init time (#69638) (#9524)
About The Pull Request
Caches some vars, merges some statements by abusing x = y returning y. Goes from .53ms per call to .45ms per call, saving over .3s of init time due to its call count.
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
commit e113d40048b5884ae3bcda4ea9df9ab6de0afc48
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Fri Jul 28 05:02:07 2023 +0000
Automatic changelog compile [ci skip]
commit 6850580e8b82782e8a717fdf9f37e05e95cdfa80
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Thu Jul 27 23:33:27 2023 -0500
Automatic changelog generation for PR #9541 [ci skip]
commit 79104afb6172ace51dd2700a807a3946504b8f7f
Author: Tyranicranger4 <80382633+Tyranicranger4@users.noreply.github.com>
Date: Thu Jul 27 21:25:31 2023 -0700
initial (#9541)
Don't know how this works, but it does.
commit 7fcc88047eff15b7bfc7a49091e540a1009bb3a4
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Fri Jul 28 00:04:46 2023 +0000
Automatic changelog compile [ci skip]
commit b321bdf10f60da6e34c0f14fb7db236cf0925507
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Thu Jul 27 18:02:14 2023 +0000
Automatic changelog compile [ci skip]
commit d1c78d1a5aedb0cf2eee358777f36428c2615daf
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Thu Jul 27 12:52:09 2023 -0500
Automatic changelog generation for PR #9186 [ci skip]
commit 09757150ce866ae738d245eb2a0d8ef387f9d92c
Author: Lamiales <110184118+CydiaLamiales@users.noreply.github.com>
Date: Thu Jul 27 20:45:25 2023 +0300
Adds more voice manipulation options (#9186)
* done
* megaphone
* megaphone-revert
* list-changes
* using a proc
* tongue-changes
* remove-random-say-from-oozelings
* suggested-changes
* Update code/modules/clothing/chameleon.dm
Co-authored-by: EvilDragonfiend <87972842+EvilDragonfiend@users.noreply.github.com>
* indentation-fix
* commented code removal
* variable-name-changes
* comment-remove
* btr_code
* code-improvements
* moar-code-impoopments
* Apply suggestions from code review
Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>
* adressing-reviews
* Update code/modules/clothing/chameleon.dm
---------
Co-authored-by: EvilDragonfiend <87972842+EvilDragonfiend@users.noreply.github.com>
Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>
commit dee674cba34f6604c2df46e773b390ae1d013471
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Thu Jul 27 12:38:52 2023 -0500
Automatic changelog generation for PR #9305 [ci skip]
commit 13d0795c5d39e639e95052da3395fc6fd8a1990a
Author: EvilDragonfiend <87972842+EvilDragonfiend@users.noreply.github.com>
Date: Fri Jul 28 02:27:47 2023 +0900
anomaly effect (#9305)
commit 5ef8ab598494ffe4b9361cd92db1b4b57f0c6b96
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Thu Jul 27 12:32:26 2023 -0500
Automatic changelog generation for PR #9362 [ci skip]
commit 7a5f151b0d3a484842d035386f92c874d87e0d00
Author: HowToLoLu <jaxsoon.ellison@gmail.com>
Date: Thu Jul 27 12:23:01 2023 -0500
Why, why was this ever a thing? (#9362)
commit 64f6bdf14f8122b30ffdb96095374805b38b226d
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Thu Jul 27 12:26:40 2023 -0500
Automatic changelog generation for PR #9283 [ci skip]
commit 73e3923678c66387c3687fa150d4308de2e006ee
Author: EvilDragonfiend <87972842+EvilDragonfiend@users.noreply.github.com>
Date: Fri Jul 28 02:20:38 2023 +0900
betterlog (#9283)
commit 3b9a170c720ca51bcd55052a1dbadc784a15306e
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Thu Jul 27 17:02:24 2023 +0000
Automatic changelog compile [ci skip]
commit 264d268383668a4610fda58bfb2187b3accbe275
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Thu Jul 27 11:43:40 2023 -0500
Automatic changelog generation for PR #9488 [ci skip]
commit 6537adbf6b40698a4da99ce253f80c1fb3b26322
Author: itsmeow <itsmeow@itsmeow.dev>
Date: Thu Jul 27 12:37:13 2023 -0400
Micros timSort slightly (#74889) (#9488)
Datum var reads are expensive, and sorting code does a lot of them.
let's work on that together, as a group.
There's maybe 250ms of sorting cost sitting in mostly global variable
work. I'd like to start chopping at that.
My tracy profiles aren't the most helpful, estimating this to save about
14% of timSort over the course of init, tho that's slightly noisy and
not the most reliable
speed
Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
commit fa9c8f78341e4070c8c193dfda702c214151c664
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Thu Jul 27 12:02:21 2023 +0000
Automatic changelog compile [ci skip]
commit ffc37a2b9b41cb8e37f62c00f32000b519e432b0
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Thu Jul 27 06:42:54 2023 -0500
Automatic changelog generation for PR #9476 [ci skip]
commit 398e9ba13ea4ae510d6df937bf992567bbb0e35d
Author: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>
Date: Thu Jul 27 13:32:18 2023 +0200
Moves organ signals to the right place (#9476)
* Moves organ signals to the right place
* Changes them to their own organ signals file
* Update code/__DEFINES/dcs/signals/signals_obj/signals_item/signals_item.dm
commit d2ee1a2baeb67ee537f4cdcec3185f70b0b42ed6
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Thu Jul 27 06:25:13 2023 -0500
Automatic changelog generation for PR #9517 [ci skip]
commit 2f414191dc1e608c5b18b8bc15cff92763470ceb
Author: EvilDragonfiend <87972842+EvilDragonfiend@users.noreply.github.com>
Date: Thu Jul 27 20:18:33 2023 +0900
follow link fix (#9517)
commit f23499adddffb085096f81f621e76e750aea855c
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Thu Jul 27 04:01:55 2023 +0000
Automatic changelog compile [ci skip]
commit 59f3e276e708bc829696b16af2d24c8620ba2feb
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Wed Jul 26 22:41:35 2023 -0500
Automatic changelog generation for PR #8842 [ci skip]
commit 26decd78684cad89ded4c9bda686f33999587f49
Author: Tsar-Salat <62388554+Tsar-Salat@users.noreply.github.com>
Date: Wed Jul 26 23:35:31 2023 -0400
Makes climbable an element + railing fixes (#8842)
* https://github.com/tgstation/tgstation/pull/55978
* https://github.com/tgstation/tgstation/pull/56518
* https://github.com/tgstation/tgstation/pull/56744
* fixes
* https://github.com/tgstation/tgstation/pull/60110
* fix
* Requested changes
* climable var for deployables
* fug
* finalcleanup
* LAZYASSOCLIST
* suggestion
* test
* alternative for deployables
commit eb06761a4bc81e1fe8ad06b468bc350da10d09d0
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Wed Jul 26 01:28:53 2023 +0000
Automatic changelog compile [ci skip]
commit 319cd86f070e4961394791d89da2699dade7f2e0
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Tue Jul 25 20:03:24 2023 -0500
Automatic changelog generation for PR #9510 [ci skip]
commit bda6f018b3debf8f91fe13004320e6871a9c18f4
Author: Tsar-Salat <62388554+Tsar-Salat@users.noreply.github.com>
Date: Tue Jul 25 20:56:46 2023 -0400
buckling pulling hotfix (#9510)
commit 222ede15e4cfed42135999cb28fa4d3b97fb9bad
Author: Lamiales <110184118+CydiaLamiales@users.noreply.github.com>
Date: Tue Jul 25 14:14:48 2023 +0300
Gives the comms agent a megaphone (#9225)
* main
* timer-delay-thing-as-asked
* comment-removal
* Apply suggestions from code review
Co-authored-by: EvilDragonfiend <87972842+EvilDragonfiend@users.noreply.github.com>
* more-suggested-stuff
* Update code/game/objects/items/devices/megaphone.dm
Co-authored-by: EvilDragonfiend <87972842+EvilDragonfiend@users.noreply.github.com>
* fixy
---------
Co-authored-by: EvilDragonfiend <87972842+EvilDragonfiend@users.noreply.github.com>
commit 78234a0b566878d798439088bd246ef5ca8ac6ba
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Tue Jul 25 05:01:51 2023 +0000
Automatic changelog compile [ci skip]
commit f843bbc2e6c5ecf924bcc32c51009081b2a0bcc6
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Mon Jul 24 23:51:36 2023 -0500
Automatic changelog generation for PR #9147 [ci skip]
commit f1141ab87171e5b573c304a79e891ad7f012f8ef
Author: Lucy <lucy@absolucy.moe>
Date: Tue Jul 25 00:45:36 2023 -0400
Stargazer slime link tweaks (#9147)
* Refactor slime link to be mind-based and use saymodes.
* Whoops, fix messed up `tgui_input_list` call.
* Refactor signal adding/removing into their own proc.
* Make a `validate_mind` proc, add case for mindshield nanites.
* Document and fixup code a bit.
* Clarify documentation of `GLOB.slime_linked_with`.
* More documentation fixup.
* Document return value.
* rgokbergtuijerguijergjuierguij
* werdf8ij49ertg3478ertyug5eryugheryugihb
* it's 5 am i'm barely aware of my own existence gimme a break
* Address reviews.
* I made a fucky wucky :3
* holy SHIT this took way longer than I was expecting
commit 8eb94c34c7e843b3ce91719875ec2ae48208265e
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Tue Jul 25 00:05:28 2023 +0000
Automatic changelog compile [ci skip]
commit 141340cc65e7943450888f3ddda49ff544134c30
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Mon Jul 24 09:02:04 2023 +0000
Automatic changelog compile [ci skip]
commit c46c9a842e5834fe5d571e250a452dc25aca7ac8
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Mon Jul 24 03:12:50 2023 -0500
Automatic changelog generation for PR #9474 [ci skip]
commit 93e369e9e0656cbd031284f9ebdb568a607f53c9
Author: Tsar-Salat <62388554+Tsar-Salat@users.noreply.github.com>
Date: Mon Jul 24 04:01:07 2023 -0400
https://github.com/tgstation/tgstation/pull/63293 (#9474)
commit 10d8d0ccc69036683b21f1861545c3486cd7a6c7
Author: Tsar-Salat <62388554+Tsar-Salat@users.noreply.github.com>
Date: Mon Jul 24 04:00:03 2023 -0400
https://github.com/tgstation/tgstation/pull/63527 (#9499)
commit 651c677768cc8d248c9e4e974903d855c7bbeaeb
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Mon Jul 24 08:02:19 2023 +0000
Automatic changelog compile [ci skip]
commit ef6d5c99c6dd32668e3f07e0b3573fdd8d46d679
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Mon Jul 24 02:59:56 2023 -0500
Automatic changelog generation for PR #9500 [ci skip]
commit ece3af37e079ead5b55dc2d5aca4228a0e55ee66
Author: Lamiales <110184118+CydiaLamiales@users.noreply.github.com>
Date: Mon Jul 24 10:52:19 2023 +0300
actually-works-this-time (#9500)
commit 16f2ff5059bc26cbdac6d6d344891ce02e512f7a
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Mon Jul 24 05:02:08 2023 +0000
Automatic changelog compile [ci skip]
commit cfb72841088c6f7b448affaf252321074cf8a089
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Sun Jul 23 23:57:12 2023 -0500
Automatic changelog generation for PR #9494 [ci skip]
commit bcda018162bbcb3b8e5077056cacad1b735b2983
Author: HowToLoLu <jaxsoon.ellison@gmail.com>
Date: Sun Jul 23 23:50:07 2023 -0500
Initial (#9494)
commit 7a3abedac8b864f143f436219b39c16811cf4d55
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Mon Jul 24 04:02:12 2023 +0000
Automatic changelog compile [ci skip]
commit d4ae64789b1c4e59fd8d5dbf4c6a0eddc83f70d5
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Sun Jul 23 22:08:05 2023 -0500
Automatic changelog generation for PR #9496 [ci skip]
commit 9fda9c76bed71750c79061243d5e03086660e754
Author: EvilDragonfiend <87972842+EvilDragonfiend@users.noreply.github.com>
Date: Mon Jul 24 12:02:52 2023 +0900
holocallsayfix2 (#9496)
commit 209d807c81e9397eb9be659c0a910febaa4c86f9
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Mon Jul 24 00:05:31 2023 +0000
Automatic changelog compile [ci skip]
commit 4a74c283785dce71164617d327147ebef00e28a8
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Sun Jul 23 23:02:02 2023 +0000
Automatic changelog compile [ci skip]
commit 138a2bc5ee2e6ae5f21b25c943d308d4c5bbc981
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Sun Jul 23 17:32:48 2023 -0500
Automatic changelog generation for PR #9432 [ci skip]
commit b016272839bb7aad69a3e6dcd4eb5549379c9fd1
Author: Lucy <lucy@absolucy.moe>
Date: Sun Jul 23 18:25:36 2023 -0400
Actually for sure fix roundstart surgery computer linking this time (#9432)
* ACTUAL PROPER surgery computer fix
* how the hell did i make that typo
* i hav big dumb
commit 4dd9daaa0a28873979c88a236ac210e5c3b07043
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Sun Jul 23 22:02:06 2023 +0000
Automatic changelog compile [ci skip]
commit 430b288636f74c2bbb03f5dbb2a84c9989ce750b
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Sun Jul 23 16:48:31 2023 -0500
Automatic changelog generation for PR #8996 [ci skip]
commit fe2094a5d65f22dcf941c9fd066ebb5e59a3753d
Author: Lucy <lucy@absolucy.moe>
Date: Sun Jul 23 17:42:22 2023 -0400
Abductors can now make custom abductee objectives (#8996)
* Abductors can now set custom abductee objectives.
* Clarify that it's optional
* Fix alignment, reset custom objective upon starting experiment.
* Add OOC filter check.
* Make ooc filter checking a bit better.
* Whoops, that's `ADMIN_LOOKUPFLW`, not `ADMIN_LOOKUP`
* what in tarnation???
* A lobotomy can now remove a custom abductee objective.
* Well, it's no longer irreversible.
* You can now cure all abductee objectives.
commit 8c482abfe4f904c588713509327926c5d1d368aa
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Sun Jul 23 19:32:42 2023 +0000
Automatic changelog compile [ci skip]
commit 07675382eb44d8d457ff16544478cec694691bf2
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Sun Jul 23 14:31:41 2023 -0500
Automatic changelog generation for PR #9229 [ci skip]
commit fa02c98c909de1edb3439d639a9114ac66cfd5b0
Author: itsmeow <itsmeow@itsmeow.dev>
Date: Sun Jul 23 15:24:41 2023 -0400
Antag Preferences and Bans Rewrite (#9229)
* Start role preferences rewrite
* Actually tie it to the preferences menu and stuff
* Today is the day I nuked antag prefs
* Holy polish
* Finish ripping out gamemode age_check
* Pass tests
* Fix
* Arrrgh
* Poll ignores
* Add back beach bartender - but this time he can speak stoner
* Update maps
* Legacy Lavaland ban
* Gamemode runtime fix
* Add per-character antag prefs, rename be_special
* No default on changelog, use update instead
* Fix MC
* Scope SQL query to new data
* Better check for exempt gamemodes
* Remove ghost role file, move procs to /client/, fix Dynamic bug allowing you to be chosen anyway
* Add enable and disable for all characters buttons
* Add Enable/Disable for all buttons to antag prefs
* Add basic living hours checks to dynamic roundstart/latejoin antags. Fix bad call to role_preference_enabled
* Make gamemodes use antag_datum to determine banning key, add living playtime requirement support
* Fixes and excom
* Fix traitor config
* Add unique antag datums to role preferences for data retrieval purposes
* Add antag ban details to prefs again
* Fix uses of antag_pick for drafted gamemodes
* Check that character.client is not null
* Fix oopsie
* Convert BAN_ROLE_ back to ROLE_
* Fix CKEY cache misses
* Fix is_banned_from not working for nonlists (oops)
* Add default instead of update
* Update schema
* Fix DB stuff
commit c26b440e834695851f34d5ea8a3220146ed7936a
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Sun Jul 23 10:02:07 2023 +0000
Automatic changelog compile [ci skip]
commit a70ac50d7fb5494504bf5491fc9a1d7ebbc49dd4
Author: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Date: Sun Jul 23 04:25:48 2023 -0500
Automatic changelog generation for PR #9489 [ci skip]
commit bf8b4642b74fe5c87917fdb677a981da599dfb19
Author: itsmeow <itsmeow@itsmeow.dev>
Date: Sun Jul 23 05:04:34 2023 -0400
I shaved 2 seconds off atom init times and it's boring (#69742) (#9489)
* I shaved 2 seconds off init times by moving some sleep tests to only run during unit testing and using ``as anything``
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
commit 636ac41e28492850a588560effd90d2b1ae5dc3d
Author: itsmeow <itsmeow@itsmeow.dev>
Date: Sun Jul 23 05:04:21 2023 -0400
Saves about 0.2 seconds of init re:air updates (#76108) (#9487)
We should be blocking the primary ssair activity updates if the
subsystem hasn't started yet
https://github.com/tgstation/dev-cycles-initiative/issues/25
Total waste of time, wins maybe 0.2 seconds of init
Co-authored-by: LemonInTheD…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports:
About The Pull Request
atomization of #8965
Turns incapacitation into a status effect. Includes clean ups from subsequent 2 prs.
check_immobilizedis removed, as it is unused in code.The trait will be applied only during incapacitations like stuns, unconciousness, or paralyzing, the same behavior as before.
Why It's Good For The Game
Simplifies checks by turning long procs into traits. Moves to making mobility more event based
Testing Photographs and Procedure
Screenshots&Videos
Disabler incapacitating someone due to stamcrit. The stamina damage calls the incapacitation status effect and applies the trait.
/mob/living/incapacitatedremains valid so long as the trait is applieddreamseeker_0jqnd4xVGu.mp4
Lol, get incapacitated, nerd.
dreamseeker_njmEVeS80y.mp4
Changelog
🆑 RKz, Rohesie, Cobby
refactor: makes incapacitation into a trait
/:cl: