Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c] [PORT] Adds Defines for Species IDs #8071

Merged
merged 2 commits into from
Nov 17, 2022
Merged

Conversation

mystery3525
Copy link
Contributor

@mystery3525 mystery3525 commented Nov 17, 2022

About The Pull Request

Ports tgstation/tgstation#59797

Simply puts species IDs into defines ("lizard" turns into #define SPECIES_LIZARD "lizard"). This does not affect any gameplay, and is purely for making sure future code doesn't go all fucked up because someone accidentally misspells something

I only changed code that was spelt correctly, so if there actually is a typo somewhere, it isn't changed

Why It's Good For The Game

Necessary for #7213, I'm going to do this one at a time as to not blow a blood vessel

Testing Photographs and Procedure

Screenshots&Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 DragonTrance ported by mystery3525
refactor: added more species defines
/:cl:

@itsmeow
Copy link
Member

itsmeow commented Nov 17, 2022

Arch was working on this already

@mystery3525
Copy link
Contributor Author

mystery3525 commented Nov 17, 2022

it isn't on the list plus
firefox_N6mH2Xcbq2
image

Copy link
Member

@itsmeow itsmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants