Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev 1.35.0 #5

Merged
merged 19 commits into from
Aug 24, 2024
Merged

Dev 1.35.0 #5

merged 19 commits into from
Aug 24, 2024

Conversation

cubicgraphics
Copy link
Member

Added values to the info part of the status api
int maxPlayers - Max players supported per server lobby
bool supportsPPModifiers
bool supportsPPDifficulties
bool serversupportsPPMap
(PP meaning per player)

@cubicgraphics
Copy link
Member Author

renamed bool serversupportsPPMap to bool supportsPPMap

@roydejong
Copy link
Contributor

@cubicgraphics I've merged the info data/endpoint into status. I don't really see the value in having two separate endpoints here, and seemingly arbitrarily splitting config data between the two. As far as I know /info has not yet been used anywhere. LMK if you see an issue with this

@cubicgraphics
Copy link
Member Author

Yep, I'm fine with this.

@cubicgraphics
Copy link
Member Author

If there is any more values you think should be added please do so

@roydejong
Copy link
Contributor

I've written up some documentation on multiplayer status handling / fields, so we have a common standard for master servers:
https://github.com/Goobwabber/MultiplayerCore/wiki/Multiplayer-Status

I've also gone ahead and added the new fields to MpStatusData in Goobwabber/MultiplayerCore@3a7e582 so it will be available for mods

If there's any other fields we want to introduce it'd be good to try and get them in before the upcoming release cycle

@cubicgraphics cubicgraphics merged commit cfd4424 into master Aug 24, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants