You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The script checks for errors after gem install but not after gem update. Consider adding error checking for the update command as well to ensure both operations complete successfully.
The script assumes that rubygems-update.gem exists in the current directory, but it doesn't verify this. Add a check to ensure the gem file exists before attempting installation.
+IF NOT EXIST rubygems-update.gem (+ echo Error: rubygems-update.gem not found in current directory+ exit /b 1+)
CALL "%RUBYBINPATH%\gem.cmd" install rubygems-update.gem --local --no-document
IF %ERRORLEVEL% NEQ 0 exit /b %ERRORLEVEL%
Apply this suggestion
Suggestion importance[1-10]: 8
__
Why: This suggestion adds important error handling by checking if the gem file exists before attempting installation. This prevents cryptic errors and provides a clear message to users when the file is missing, improving robustness.
Medium
Add error handling
The script doesn't check for errors after running the system update command. Add error handling to ensure the update completed successfully.
Why: Adding error handling for the system update command is important for script reliability. The current implementation doesn't check if the update succeeded, which could lead to silent failures. This change ensures the script exits with the appropriate error code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Enhancement
Description
Add Ruby 3.4.3 release configuration and metadata
Introduce install script for RubyGems update in Ruby 3.4.3
Update release and build properties for new version
Register Ruby 3.4.3 in releases list
Changes walkthrough 📝
install.bat
Add RubyGems install/update script for Ruby 3.4.3bin/ruby3.4.3/rubygems/install.bat
bearsampp.conf
Add Ruby 3.4.3 configuration filebin/ruby3.4.3/bearsampp.conf
rubygems.properties
Add RubyGems properties for Ruby 3.4.3bin/ruby3.4.3/rubygems/rubygems.properties
releases.properties
Add Ruby 3.4.3 to releases registryreleases.properties
build.properties
Update bundle release version for new Ruby releasebuild.properties