Skip to content

Conversation

@N6REJ
Copy link
Contributor

@N6REJ N6REJ commented Jul 31, 2025

PR Type

Enhancement


Description

  • Added Bruno version 2.8.1 configuration and release

  • Updated bundle release date to 2025.7.31

  • Added new version entry to releases registry


Diagram Walkthrough

flowchart LR
  A["New bearsampp.conf"] --> B["Version 2.8.1"]
  C["Updated build.properties"] --> D["Release 2025.7.31"]
  E["Updated releases.properties"] --> F["New download URL"]
Loading

File Walkthrough

Relevant files
Configuration changes
bearsampp.conf
New Bruno 2.8.1 configuration file                                             

bin/bruno2.8.1/bearsampp.conf

  • Added new configuration file for Bruno version 2.8.1
  • Defined brunoVersion as "2.8.1" and brunoExe as "bruno.exe"
+2/-0     
build.properties
Updated bundle release date                                                           

build.properties

  • Updated bundle.release from 2025.6.13 to 2025.7.31
+1/-1     
releases.properties
Added Bruno 2.8.1 release entry                                                   

releases.properties

  • Added new release entry for Bruno version 2.8.1
  • Mapped to download URL with 2025.7.31 release date
+1/-0     

@N6REJ N6REJ added bug Something isn't working enhancement New feature or request labels Jul 31, 2025
@qodo-merge-pro
Copy link
Contributor

qodo-merge-pro bot commented Jul 31, 2025

PR Reviewer Guide 🔍

(Review updated until commit 43c2ed7)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Version Ordering

The new version 2.8.1 is added at the end of the file, but it should be inserted in proper version order between existing entries to maintain consistency with semantic versioning sequence.

2.8.1 = https://github.com/Bearsampp/module-bruno/releases/download/2025.7.31/bearsampp-bruno-2.8.1-2025.7.31.7z

@qodo-merge-pro
Copy link
Contributor

qodo-merge-pro bot commented Jul 31, 2025

PR Code Suggestions ✨

Latest suggestions up to 43c2ed7

CategorySuggestion                                                                                                                                    Impact
General
Remove unnecessary quotes from values

The configuration values should not be enclosed in double quotes for property
files. Property files typically store values as plain text without quotes unless
the quotes are part of the actual value.

bin/bruno2.8.1/bearsampp.conf [1-2]

-brunoVersion = "2.8.1"
-brunoExe = "bruno.exe"
+brunoVersion = 2.8.1
+brunoExe = bruno.exe
  • Apply / Chat
Suggestion importance[1-10]: 6

__

Why: The suggestion correctly identifies that using quotes for values in this .conf file is inconsistent with other property files in the PR, and removing them improves consistency and may prevent potential parsing issues.

Low
  • More

Previous suggestions

Suggestions
CategorySuggestion                                                                                                                                    Impact
General
Remove unnecessary quotes from values

The configuration values should not be quoted in properties files unless quotes
are part of the actual value. Remove the quotes around the version and
executable name for proper parsing.

bin/bruno2.8.1/bearsampp.conf [1-2]

-brunoVersion = "2.8.1"
-brunoExe = "bruno.exe"
+brunoVersion = 2.8.1
+brunoExe = bruno.exe
Suggestion importance[1-10]: 5

__

Why: The suggestion correctly notes that quotes are often not needed in property files; removing them aligns with the style of other property files in the PR, improving consistency.

Low

remove commented line
@qodo-merge-pro
Copy link
Contributor

qodo-merge-pro bot commented Aug 4, 2025

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Remove unnecessary quotes from values

The configuration values should not be quoted in properties files unless quotes
are part of the actual value. Remove the quotes around the version and
executable name for proper parsing.

bin/bruno2.8.1/bearsampp.conf [1-2]

-brunoVersion = "2.8.1"
-brunoExe = "bruno.exe"
+brunoVersion = 2.8.1
+brunoExe = bruno.exe
  • Apply / Chat
Suggestion importance[1-10]: 5

__

Why: The suggestion correctly notes that quotes are often not needed in property files; removing them aligns with the style of other property files in the PR, improving consistency.

Low
  • More

@jwaisner jwaisner merged commit 817514a into main Aug 4, 2025
@jwaisner jwaisner deleted the 2.8.1 branch August 4, 2025 23:41
@qodo-merge-pro
Copy link
Contributor

qodo-merge-pro bot commented Aug 4, 2025

Persistent suggestions updated to latest commit 43c2ed7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request Review effort 1/5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants