1.29.1 & 1.30.0 releases

[N6REJ]

PR Type

enhancement, configuration changes

---

Description

• Added a new configuration file bearsampp.conf for Bruno version 1.29.1.
• Updated the build.properties to reflect a new release date of 2024.9.18.
• Modified build.xml to accommodate changes in the directory structure, specifically for bruno.exe.
• Added a new release entry in releases.properties for version 1.29.1.

---

Changes walkthrough 📝

	Relevant files
Configuration changes	bearsampp.conf Add configuration file for Bruno version 1.29.1                    bin/bruno1.29.1/bearsampp.conf Added new configuration file for version 1.29.1. Set brunoVersion to "1.29.1". Specified brunoExe as "Bruno.exe". +4/-0      build.properties Update bundle release date in properties                                  build.properties Updated bundle.release date to 2024.9.18. +1/-1      releases.properties Add release entry for Bruno version 1.29.1                              releases.properties Added release entry for version 1.29.1. +1/-0
Enhancement	build.xml Update build process for new directory structure                  build.xml Modified file paths for bruno.exe to include win-unpacked. Adjusted copy operations to new directory structure. +2/-2

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[qodo-merge-pro]

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Key issues to review Unused Configuration The bundleRelease property is commented out and may be unnecessary if not used elsewhere in the project. Potential File Path Issue The change in file path for bruno.exe might cause issues if other parts of the project still expect the old path structure. Duplicate Entry There are two entries for version 1.28.0, which may cause confusion or issues with version management.

[qodo-merge-pro]

PR Code Suggestions ✨

Category	Suggestion	Score
Maintainability	Remove duplicate version entry to maintain clean and consistent version management Remove the duplicate entry for version 1.28.0. Having multiple entries for the same version can lead to confusion and potential issues in version management. releases.properties [1-3] 1.28.0 = https://github.com/Bearsampp/module-bruno/releases/download/2024.9.13/bearsampp-bruno-1.28.0-2024.9.13.7z 1.29.1 = https://github.com/Bearsampp/module-bruno/releases/download/2024.9.18/bearsampp-bruno-1.29.1-2024.9.18.7z -1.28.0 = https://github.com/Bearsampp/module-bruno/releases/download/2024.9.13/bearsampp-bruno-1.28.0-2024.9.13.7z Apply this suggestion Suggestion importance[1-10]: 9 Why: Removing the duplicate entry for version 1.28.0 is crucial for avoiding confusion and potential issues in version management, ensuring clarity and consistency.	9
	Remove or update commented out configuration to improve maintainability Consider removing the commented out bundleRelease property or updating it with the correct release date. Commented out configuration can lead to confusion and maintenance issues. bin/bruno1.29.1/bearsampp.conf [1-4] brunoVersion = "1.29.1" brunoExe = "Bruno.exe" -#bundleRelease = "2024.9.12" - Apply this suggestion Suggestion importance[1-10]: 7 Why: Removing or updating the commented out bundleRelease property can improve maintainability by reducing confusion and potential errors in configuration management.	7
Possible issue	✅ Add a condition to check for directory existence before copying files Consider adding a condition to check if the 'win-unpacked' directory exists before copying its contents. This can prevent potential errors if the directory structure changes in future versions. build.xml [28-30] -<copy todir="${bundle.tmp.prep.path}/${bundle.folder}" overwrite="true"> - <fileset dir="${bundle.srcdest}/win-unpacked"/> -</copy> +<if> + <available file="${bundle.srcdest}/win-unpacked" type="dir" /> + <then> + <copy todir="${bundle.tmp.prep.path}/${bundle.folder}" overwrite="true"> + <fileset dir="${bundle.srcdest}/win-unpacked"/> + </copy> + </then> + <else> + <echo message="Warning: ${bundle.srcdest}/win-unpacked directory not found." /> + </else> +</if> [Suggestion has been applied] Suggestion importance[1-10]: 8 Why: Adding a condition to check if the 'win-unpacked' directory exists before copying its contents can prevent errors and improve robustness, especially if the directory structure changes in future versions.	8

💡 Need additional feedback ? start a PR chat

[qodo-merge-pro]

Suggestion: Add a condition to check for directory existence before copying files [Possible issue, importance: 8]

Suggested change

	<copy todir="${bundle.tmp.prep.path}/${bundle.folder}" overwrite="true">
	<fileset dir="${bundle.srcdest}"/>
	<fileset dir="${bundle.srcdest}/win-unpacked"/>
	</copy>